Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 444730

Summary: sys-libs/libutempter: please review prefix changes
Product: Gentoo Linux Reporter: Christoph Junghans (RETIRED) <junghans>
Component: [OLD] baselayoutAssignee: Gentoo's Team for Core System packages <base-system>
Status: RESOLVED FIXED    
Severity: normal CC: prefix, x11
Priority: Normal Keywords: Inclusion, InVCS, PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 315803    
Attachments: patch against libutempter-1.1.6.ebuild

Description Christoph Junghans (RETIRED) gentoo-dev 2012-11-25 19:38:02 UTC
Created attachment 330568 [details, diff]
patch against libutempter-1.1.6.ebuild

Changes to be added as libutempter-1.1.6-r1:
- prefixed include, mandir and libdir
- don't run fowners and fperms in prefix
- ${ROOT} -> ${EROOT}
- added prefix keywords
Comment 1 SpanKY gentoo-dev 2012-11-26 06:04:02 UTC
Comment on attachment 330568 [details, diff]
patch against libutempter-1.1.6.ebuild

>-	fowners root:utmp /usr/$(get_libdir)/misc/utempter/utempter
>-	fperms 2755 /usr/$(get_libdir)/misc/utempter/utempter
>+	use prefix || fowners root:utmp /usr/$(get_libdir)/misc/utempter/utempter
>+	use prefix || fperms 2755 /usr/$(get_libdir)/misc/utempter/utempter

merge into a single if statement:

 if ! use prefix ; then
    ... fowners/fperms stuff ...
 fi

fix that and feel free to commit
Comment 2 Christoph Junghans (RETIRED) gentoo-dev 2012-11-26 15:57:26 UTC
Committed, thanks.