Summary: | dev-lang/spidermonkey-1.8.5 does not respect CFLAGS/CXXFLAGS | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Denis M. (Phr33d0m) <god> |
Component: | [OLD] Development | Assignee: | Mozilla Gentoo Team <mozilla> |
Status: | RESOLVED FIXED | ||
Severity: | QA | CC: | hasufell, nikoli |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
build log: dev-lang:spidermonkey-1.8.5-r2.log
spidermonkey-24.2.0-r1.ebuild.diff spidermonkey-17.0.0-r3.ebuild.diff spidermonkey-24.2.0-r1.ebuild.diff |
Description
Denis M. (Phr33d0m)
2012-11-21 06:21:30 UTC
Created attachment 330108 [details]
build log: dev-lang:spidermonkey-1.8.5-r2.log
is there a technical reason this is not fixed? :24 is still affected (In reply to Julian Ospald (hasufell) from comment #2) > is there a technical reason this is not fixed? > > :24 is still affected There are much bigger bugs that are being addressed the minor little annoyances such as this. (In reply to Jory A. Pratt from comment #3) > (In reply to Julian Ospald (hasufell) from comment #2) > > is there a technical reason this is not fixed? > > > > :24 is still affected > > There are much bigger bugs that are being addressed the minor little > annoyances such as this. O3 can cause bugs as well. I'll try to come up with a patch. Created attachment 377158 [details, diff]
spidermonkey-24.2.0-r1.ebuild.diff
Created attachment 377160 [details, diff]
spidermonkey-17.0.0-r3.ebuild.diff
hm, I think that did not catch all Created attachment 377162 [details, diff]
spidermonkey-24.2.0-r1.ebuild.diff
This should catch all of them. The patch is the same for all 3 slots.
Thanks for the patch! Jory, your thoughts on whether this should be applied unconditionally or if maybe we should add "custom-cflags / custom-optimization" (via mozcoreconf-2.eclass) now, to normalize spidermonkey with the other mozilla packages? (In reply to Ian Stakenvicius from comment #9) > Thanks for the patch! > > Jory, your thoughts on whether this should be applied unconditionally or if > maybe we should add "custom-cflags / custom-optimization" (via > mozcoreconf-2.eclass) now, to normalize spidermonkey with the other mozilla > packages? It is fine unconditionally. Fixed in :24 + 02 Jun 2014; Ian Stakenvicius (_AxS_) <axs@gentoo.org> + -spidermonkey-24.2.0-r1.ebuild, spidermonkey-24.2.0-r2.ebuild: + dropped optimizations so build system will respect cflags, bug 444126, thanks + to hasufell for patches; removed old :24 ebuild Has been fixed for some time now. |