Bug 443800

Summary:	sys-freebsd/freebsd-ubin-9.1_rc3 -- please remove ee and keywords app-editors/ee
Product:	Gentoo/Alt	Reporter:	Yuta SATOH <nigoro.dev>
Component:	FreeBSD	Assignee:	Gentoo/BSD Team <bsd+disabled>
Status:	RESOLVED INVALID
Severity:	enhancement
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	FreeBSD
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	patch for freebsd-ubin-9.1_rc3.ebuild app-editors/ee/files/ee-1.5.2-fbsd.patch patch for app-editors/ee/ee-1.5.2.ebuild

Description Yuta SATOH 2012-11-18 15:34:28 UTC

ee is easy editor.
Gentoo's package is app-editors/ee.

I think better to remove ee from -ubin, add the keywords in app-editors/ee.

# equery b ee
 * Searching for ee ...
sys-freebsd/freebsd-ubin-9.1_rc3 (/usr/bin/ee)


Reproducible: Always

Comment 1 Yuta SATOH 2012-11-18 15:46:51 UTC

Created attachment 329860 [details, diff]
patch for freebsd-ubin-9.1_rc3.ebuild

Comment 2 Yuta SATOH 2012-11-18 15:54:32 UTC

Created attachment 329862 [details, diff]
app-editors/ee/files/ee-1.5.2-fbsd.patch

signal.h on FreeBSD not defined SIGUNUSED.
Following compile error occurs.

Compile pass when you apply this sample patch.

gmake[1]: Entering directory `/var/tmp/portage/app-editors/ee-1.5.2/work/easyedit-1.5.2'
x86_64-gentoo-freebsd9.1-gcc ee.c -o ee -DHAS_UNISTD -DHAS_STDARG -DHAS_STDLIB -DHAS_CTYPE -DHAS_SYS_IOCTL -DHAS_SYS_WAIT   -DSLCT_HDR -O2 -pipe -mtune=generic   -lcurses
ee.c: In function 'main':
ee.c:555:30: error: 'SIGUNUSED' undeclared (first use in this function)
ee.c:555:30: note: each undeclared identifier is reported only once for each function it appears in
ee.c: In function 'get_options':

Comment 3 Yuta SATOH 2012-11-18 15:55:37 UTC

Created attachment 329864 [details, diff]
patch for app-editors/ee/ee-1.5.2.ebuild

Comment 4 Alexis Ballier gentoo-dev

2012-11-18 22:48:37 UTC

well, if we remove some packages from the system set then it shouldnt need a patch. please check with ee's upstream if they support fbsd first, and make sure they apply your patch. did you diff the ee releases and fbsd ee source code?

Comment 5 Yuta SATOH 2012-11-28 11:46:45 UTC

(In reply to comment #4)
> well, if we remove some packages from the system set then it shouldnt need a
> patch. please check with ee's upstream if they support fbsd first, and make
> sure they apply your patch. did you diff the ee releases and fbsd ee source
> code?

ee source code that is included in FreeBSD has been fixed some issues.
In addition, it is user-friendly editor included in stages. (see #443810)

I think better to keep ee in freebsd-ubin.

Sorry for the noise.