Bug 443556 – sys-devel/clang-3.1 - Updated ebuild with +python and +doc

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Alex Turbov 2012-11-16 20:32:25 UTC]

clang API documentation (generated by doxygen) is really useful if you are trying to use clang from your application or developing plugins/extensions for it.
as well as python binding.

here is updated ebuild w/ 2 new USE flags added.

[Comment 1 Alex Turbov 2012-11-16 20:33:02 UTC]

Created attachment 329672 [details]
new ebuild w/ +python and +doc USE flags

[Comment 2 Alex Turbov 2012-11-16 20:35:01 UTC]

Created attachment 329674 [details]
new ebuild w/ +python and +doc USE flags

sorry, the previous one was wrong. here is a better one.

[Comment 3 Tom Wijsman (TomWij) (RETIRED) 2012-11-17 00:57:33 UTC]

Can you provide a clean minimal diff? I just ran a diff against the latest revision in portage and it's hard to see the changes from the diff, did you change a lot of indentation by accident?

[Comment 4 Alex Turbov 2012-11-17 01:38:47 UTC]

Created attachment 329688 [details, diff]
"clean" patch by diff -ub

[Comment 5 Alex Turbov 2012-11-17 01:40:22 UTC]

(In reply to comment #3)
> Can you provide a clean minimal diff? I just ran a diff against the latest
> revision in portage and it's hard to see the changes from the diff, did you
> change a lot of indentation by accident?

not by accedent... my favorite editor configured that way...
btw, you may use `diff -b` to avoid spaces counting...
anyway I've attached a 'clean' patch

[Comment 6 Tom Wijsman (TomWij) (RETIRED) 2012-11-17 01:47:48 UTC]

Thanks, haven't considered that and will do so in the future; I usually attach a diff to ease the job. Assigned the bug to the maintainers.

[Comment 7 Michał Górny 2012-11-17 08:49:04 UTC]

Thanks for the patch. I have some doubts, however.

Firstly, do you defer documentation building to src_install()? It should happen in src_compile(), and src_install() should just install the files.

Secondly, would you mind if we deferred the Python-related changes for a few days? I'd like to make it use pythonr-r1, and for that I'd need a few more days to get feedback.

[Comment 8 Alex Turbov 2012-11-17 09:03:06 UTC]

(In reply to comment #7)
> Thanks for the patch. I have some doubts, however.
> 
> Firstly, do you defer documentation building to src_install()? It should
> happen in src_compile(), and src_install() should just install the files.
> 

yep, I did that in my first version... but unfortunately 'install-doxygen' target declared in the clang/docs/Makefile depends on another one called 'doxygen'. The latter is declared as PHONEY, so if you'll put `make doxygen` into src_compile() it will build API dox (wasting noticable time), and then on `make install` it will rebuild all (same) docs again... that behaviour is definitely silly, but its in upstream :( ... 

> Secondly, would you mind if we deferred the Python-related changes for a few
> days? I'd like to make it use pythonr-r1, and for that I'd need a few more
> days to get feedback.

yeah, sure

[Comment 9 Bernard Cafarelli 2015-10-16 11:22:59 UTC]

Cleaning old llvm/clang bugs, USE=doc on recent llvm ebuilds also installs clang documentation, and python parts in clang are installed (not really worth patching to disable the install). So everything done for this bug :)

[Comment 10 Alex Turbov 2015-10-19 13:36:26 UTC]

Unfortunately setting USE+=doc on llvm do not produce clang API documentation :(

[Comment 11 Bernard Cafarelli 2015-10-19 15:42:23 UTC]

Do you mean the doxygen doc? If it is different from the sphinx doc, we can enable it (the ebuilds have hardcoded -DLLVM_ENABLE_DOXYGEN=OFF)

If that is the case, can you open a new bug for this? Thanks!