Bug 442808 – sys-kernel/gentoo-sources sys-kernel/hardened-sources 3.6.5, 3.6.6 keyspan driver GPF oops

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Hank Leininger 2012-11-11 20:44:58 UTC]

There is a bug in the keyspan USB serial driver in 3.6.5 and 3.6.6 (and possibly 3.6.7 when it is released).  A very simple patch was posted to lkml that fixes the problem; please add that patch to the standard gentoo kernel patches.  I will attach patches that apply cleanly to gentoo-sources and hardened-sources 3.6.6.

Reproducible: Always

Steps to Reproduce:
1. Boot gentoo-sources 3.6.5 or 3.6.6 with a keyspan USB-to-serial adaptor connected (tested with the 4port adaptor).
2. Run anything that opens the keyspan's /dev/ttyUSBn, such as minicom.
3. Watch the oops.



This was identified quickly on lkml as a simple typo/cut-and-paste bug:

http://marc.info/?l=linux-usb&m=135253886011882&w=2

The patch worked for the original submitter, and for me just now.  Note that at the end of the thread, the kernel devs suggest this fix may be too late to make it into 3.6.7.  So, more reason to add it to genpatches (although I don't know the policy about issuing -r revisions for just driver bugfixes).

I'll attach a version of the patch that applies cleanly to gentoo-sources-3.6.6 and hardened-sources-3.6.6.

Also, credit to the original reporter, Richard, who is a Gentoo user:

http://marc.info/?l=linux-kernel&m=135249033128528&w=2

(I could not find an existing Gentoo bug about this; apologies if he had already created one.)

[Comment 1 Hank Leininger 2012-11-11 20:49:35 UTC]

Created attachment 329284 [details]
oops output when opening keyspan serial port

[Comment 2 Hank Leininger 2012-11-11 20:51:23 UTC]

Created attachment 329286 [details, diff]
Fix for gentoo-sources-3.6.6 keyspan USB serial oops

[Comment 3 Tom Wijsman (TomWij) (RETIRED) 2012-11-12 00:16:46 UTC]

Gentoo tries to defer from the upstream kernel as minimal as possible, since the patch has not been acknowledged yet (as far as I can see) and is not yet in the stable queue or linus' repository we can't yet add it to genpatches.

Once the bug gets acknowledged and/or shows up in the stable queue it might be added to genpatches, that's up to the kernel maintainers to decide. They are assigned to the bug now so will follow this up as well, if you see an acknowledgement online or see it appear in the stable queue or linus' repository and we haven't reacted on the bug yet then feel free to let us know.

[Comment 4 Mike Pagano 2012-11-26 22:04:37 UTC]

This is in 3.6.8, which I am releasing tonight.

[Comment 5 Mike Pagano 2012-12-19 19:11:49 UTC]

Released