Bug 441674

Summary:	=net-libs/webkit-gtk-1.8.3-r{200,300}: do not include execinfo.h/call backtrace() on a uclibc system
Product:	Gentoo Linux	Reporter:	Anthony Basile <blueness>
Component:	[OLD] Library	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	UPSTREAM
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://bugs.webkit.org/show_bug.cgi?id=102946
Whiteboard:
Package list:		Runtime testing required:	---

Description Anthony Basile gentoo-dev

2012-11-04 01:44:41 UTC

webkit-gtk fails to build on a uclibc system because Source/JavaScriptCore/wtf/Assertions.cpp assumes that all linux systems have /usr/include/execinfo.h and provide backtrace().  But uclibc does not.  Its straightforward to extend the test to see if its also a uclibc system and not include execinfo.h or call backtrace().

Comment 1 Anthony Basile gentoo-dev

2012-11-04 01:51:27 UTC

I have a patch on my overlay:

http://git.overlays.gentoo.org/gitweb/?p=proj/hardened-dev.git;a=blob;f=net-libs/webkit-gtk/files/webkit-gtk-1.8.3-disable-backtrace-uclibc.patch;h=0646ec4e62fad0d15ff91e5fe4c2285142e58370;hb=0c7ecdcba26a359b85e83e0b5b92fec9156b5c96

I can upstream it for you.

Comment 2 Anthony Basile gentoo-dev

2012-11-04 03:33:33 UTC

(In reply to comment #0)
>But uclibc does not.

I should add that it "usually" doesn't because uclibc is highly configurable and you can configure it to have backtrace.

Comment 3 Alexandre Rostovtsev (RETIRED) gentoo-dev

2012-11-04 03:59:17 UTC

(In reply to comment #1)
> I can upstream it for you.

Please do so, and give the webkit bugzilla report url here (unless you are committing it to webkit svn directly).

Comment 4 Alexandre Rostovtsev (RETIRED) gentoo-dev

2012-11-04 06:31:03 UTC

Applied in portage and gnome overlay without a revision bump (I don't want to force all webkit-gtk users to rebuild this very slow-compiling package for a small change that only affects uclibc).

The patch in the gnome overlay at http://git.overlays.gentoo.org/gitweb/?p=proj/gnome.git;a=blob;f=net-libs/webkit-gtk/files/webkit-gtk-1.10.1-disable-backtrace-uclibc.patch should apply to webkit-gtk-1.11.1, so that's the version that you probably should submit upstream.

>  04 Nov 2012; Alexandre Rostovtsev <tetromino@gentoo.org>
>  webkit-gtk-1.6.1-r201.ebuild, webkit-gtk-1.6.1-r301.ebuild,
>  webkit-gtk-1.6.3-r200.ebuild, webkit-gtk-1.6.3-r300.ebuild,
>  webkit-gtk-1.8.2-r200.ebuild, webkit-gtk-1.8.2-r300.ebuild,
>  webkit-gtk-1.8.3-r200.ebuild, webkit-gtk-1.8.3-r300.ebuild,
>  +files/webkit-gtk-1.8.3-disable-backtrace-uclibc.patch:
>  Add patch to fix uclibc backtrace() problem (bug #441674, thanks to Anthony
>  Basile). No revision bump since this only affects uclibc users, and
>  webkit-gtk takes a long time to rebuild. Update license.

Comment 5 Anthony Basile gentoo-dev

2012-11-04 13:35:55 UTC

(In reply to comment #4)
> Applied in portage and gnome overlay without a revision bump (I don't want
> to force all webkit-gtk users to rebuild this very slow-compiling package

As it should be because people who already have it compiled don't need this.

Thanks!

Comment 6 Anthony Basile gentoo-dev

2012-11-21 16:08:21 UTC

I have submitted this patch upstream:

https://bugs.webkit.org/show_bug.cgi?id=102946