Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 440596

Summary: The games eclass outputs elog messages that shoud only be displayed for new installs
Product: Gentoo Linux Reporter: poletti.marco
Component: EclassesAssignee: Gentoo Linux bug wranglers <bug-wranglers>
Status: RESOLVED WORKSFORME    
Severity: normal CC: pacho
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 440214    

Description poletti.marco 2012-10-31 11:41:28 UTC
When emerging a package using the games eclass, the following elog messages are displayed:

 * Remember, in order to play games, you have to
 * be in the 'games' group.
 * Just run 'gpasswd -a <USER> games', then have <USER> re-login.

Such messages should only be displayed when the package is a new install.
These situations can be checked in the eclass as follows:

if ! has_version "${PN}"; then

See the tracker bug 440214 for more details.


Reproducible: Always
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2012-10-31 15:47:31 UTC
If you don't want to see it, set GAMES_SHOW_WARNING=no

The fact that the package is already installed doesn't mean the person doing the current install saw it before.

For lack of a better status... WORKSFORME.
Comment 2 Pacho Ramos gentoo-dev 2012-11-11 14:02:45 UTC
(In reply to comment #1)
> If you don't want to see it, set GAMES_SHOW_WARNING=no
> 
> The fact that the package is already installed doesn't mean the person doing
> the current install saw it before.
> 
> For lack of a better status... WORKSFORME.

I discovered that variable time ago while reading eclass... why not suggest that setting in the shown message itself? That way people will use it once they add their users to proper group