Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 440564

Summary: app-editors/vim-7.3.409: some elog messages should only be shown when upgrading from an old enough package.
Product: Gentoo Linux Reporter: poletti.marco
Component: Current packagesAssignee: Vim Maintainers <vim>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 440214    

Description poletti.marco 2012-10-31 11:29:28 UTC
Disclaimer: this bug has been filed in a semi-automated manner.

When emerging the package app-editors/vim-7.3.409, the following elog messages are displayed:

 * Vim 7 includes an integrated spell checker. You need to install
 * word list files before you can use it. There are ebuilds for
 * some of these named app-vim/vim-spell-*. If your language of
 * choice is not included, please consult vim-spell.eclass for
 * instructions on how to make a package.
 * Note that the English word lists are no longer installed by
 * default.
 * To see what's new in this release, use :help version7.txt

Such messages should only be displayed when the package is upgraded from an old enough package (and possibly for new installs).
These situations can be checked in the ebuild as follows:

if has_version '<app-editors/vim-1.0'; then

Or, if the message should also be displayed for new installs:

if !has_version 'app-editors/vim' || has_version '<app-editors/vim-1.0'; then

Remember to replace 1.0 with the right version number.

See the tracker bug 440214 for more details.
Comment 1 Walter Dnes 2013-06-02 23:33:24 UTC
Hello, is anybody there? The EWARN message has been trimmed down to a couple of lines...

> WARN: postinst
> Note that the English word lists are no longer installed by default.

*BUT IT IS STILL POLLUTING MY /var/log/portage/elog DIRECTORY*. This is rather annoying, because I almost always check that directory after world updates, etc. A Google search turns up this text in...

http://forums.funtoo.org/viewtopic.php?id=608  (See post #3).

That post dates back to July 2011. It's now June 2013. That's almost 2 years already. This message should be dropped out of the ebuild. I question whether it rated being an EWARN in the first place. But after 2 years, can we please just turf it already?
Comment 2 Tim Harder gentoo-dev 2013-06-09 23:31:19 UTC
(In reply to Walter Dnes from comment #1)
> Hello, is anybody there? The EWARN message has been trimmed down to a couple
> of lines...
> ... 

I'm waiting until all vim related ebuilds are >= EAPI 4 so it can be done easily with ${REPLACING_VERSIONS} in pkg_postinst instead of having to use has_version and saving to a variable in pkg_preinst.
Comment 3 Tim Harder gentoo-dev 2014-01-25 21:12:18 UTC
This shouldn't be an issue anymore with current versions that don't use the eclass anymore.