Summary: | net-nds/rpcbind - add support for warm restarts of rpcbind daemon | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sean McGovern <gseanmcg> |
Component: | New packages | Assignee: | Network Filesystems <net-fs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
patch for rpcbind ebuild
patch to disable warmstart advertisement in manpage and daemon socket file for systemd service file for systemd patch to rpcbind metadata.xml for new warmstarts USE flag revised patch for rpcbind ebuild OPTIONAL new confd with warmstart flag added |
Description
Sean McGovern
2012-10-30 15:20:48 UTC
Created attachment 327788 [details, diff]
patch for rpcbind ebuild
Created attachment 327790 [details, diff]
patch to disable warmstart advertisement in manpage and daemon
Created attachment 327804 [details]
socket file for systemd
Created attachment 327806 [details]
service file for systemd
Created attachment 327808 [details, diff]
patch to rpcbind metadata.xml for new warmstarts USE flag
The systemd service does not enable warmstarts by default. Should I add an einfo/ewarn to the ebuild for this? I've already converted my setup to systemd, but I can also modifying the initscript if so desired. I would need someone else to test it, however. Comment on attachment 327804 [details]
socket file for systemd
i'm not interested in systemd and seems unrelated to warmstart. do that in a sep bug so someone else can review it.
Comment on attachment 327788 [details, diff] patch for rpcbind ebuild >+ use warmstarts && myconf+=" --with-statedir=${EPREFIX}/run/${PN}" i don't think you need to make this conditional on USE=warmstarts > src_install() { > emake DESTDIR="${D}" install || die > dodoc AUTHORS ChangeLog NEWS README you converted to EAPI=4, so change these two lines to `default` >- newinitd "${FILESDIR}"/rpcbind.initd rpcbind || die >- newconfd "${FILESDIR}"/rpcbind.confd rpcbind || die >+ newinitd "${FILESDIR}"/${PN}.initd ${PN} || die >+ newconfd "${FILESDIR}"/${PN}.confd ${PN} || die since you converted to EAPI=4, drop the '|| die' OK, will modify and re-send soon. Thanks for reviewing. :) Created attachment 327836 [details, diff]
revised patch for rpcbind ebuild
Created attachment 327838 [details]
OPTIONAL new confd with warmstart flag added
*ping!* *ping^2* *ping^3!* Added in 0.2.1. However since it's not enabled by default I didn't add a new default conf.d that enables it. Also, the systemd stuff should be done in a different bug like mentioned previously. |