Summary: | net-misc/ntp ntp-client init script should change "need net" to "after net" | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Matthew Schultz <mattsch> |
Component: | New packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | antonlacon, grimm26, j6yNRdsH5Fc3, toralf |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=463974 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 439092 |
Description
Matthew Schultz
2012-10-24 21:00:29 UTC
except ntp-client runs exactly once and does so by connecting over the network to a remote system I still recommend dropping "need net" and having the user use rc_need in the conf.d file to set the interface that the service needs. See Diego's blog entry on the subject [1]. [1] http://blog.flameeyes.eu/2012/10/may-i-have-a-network-connection-please for services that listen passively, culling "need net" makes sense. for services that actively make connections, "need net" is a perfectly fine default. requiring the majority of people to add explicit "rc_need" settings to every network connecting service to satisfy the tiny number of people who have an unusual setup is wrong. the point of defaults is to be sane out of the box. ntp-client has been this way for almost a decade and hasn't been an issue. (In reply to comment #3) > for services that listen passively, culling "need net" makes sense. for > services that actively make connections, "need net" is a perfectly fine > default. requiring the majority of people to add explicit "rc_need" > settings to every network connecting service to satisfy the tiny number of > people who have an unusual setup is wrong. the point of defaults is to be > sane out of the box. > > ntp-client has been this way for almost a decade and hasn't been an issue. I agree with William. What would be the problem with having the ebuild put rc_need in the conf.d configuration file set to default on instead of making the user add it? I'm actually okay with Mike. There are corner cases for this, but for instance on LXC you're _not_ supposed to use ntp-client at all, so that's not one of them. For NFS root, the easy way out would be to set rc_need="!net". On the other hand... what about making it "after net"? (In reply to comment #4) you skipped the "reasonable default" part of my reply (In reply to comment #5) "after net" should be fine should be all set now in the tree; thanks for the report! Commit message: Change "need net" to "after net" http://sources.gentoo.org/net-misc/ntp/files/ntp-client.rc?r1=1.11&r2=1.12 *** Bug 449696 has been marked as a duplicate of this bug. *** *** Bug 463974 has been marked as a duplicate of this bug. *** *** Bug 510406 has been marked as a duplicate of this bug. *** *** Bug 532434 has been marked as a duplicate of this bug. *** |