| Summary: | evms-2.3.0 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Andreas Simon <andreas.w.simon> |
| Component: | New packages | Assignee: | x86-kernel (DEPRECATED) <x86-kernel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | iggy |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Patch for evms
My Ebuild |
||
|
Description
Andreas Simon
2004-03-07 05:15:42 UTC
Created attachment 26981 [details, diff]
Patch for evms
Made a patch evms-2.2.2 -> evms-2.3.0
Although the old ebuild still works I made a patch.
The patch does:
* Install the README file.
* install the sample configuration into the docdir instead of /etc
(the default config file is still installed into /etc)
* install the kernel patches which come handy for people which compile
their own kernels. (for 2.6.x kernels all those patches are optional
and only add features but are not mandatory to run evms)
I propose this ebuild I have a doubt: the evms.conf and evms.conf.sample where they must be installs to you ?? Created attachment 27076 [details]
My Ebuild
The old ebuild installed both evms.conf and evms.conf.sample in /etc. But usually ebuilds install example configurations into doc dir (think of all the clutter in /etc if every ebuild would install example configs into /etc, especially since many ebuilds come with many examples). I don't think evms should be an exception. Also I don't like to have files under /etc which are never ever used at all. Examples IMO don't belong into /etc but into /usr/share/doc. OTOH because evms.conf and evms.conf.example are the same I think it doesn't make sense to install evms.conf.example at all. If I think about it I would recommend to not install evms.conf.example at all -- /etc/evms.conf is enough. Brian what's your opinion on the proposed changes? I think at least the README could be installed. I knew there was a bug for this somewhere. I added your stuff to the ebuild, didn't rev bump it in case I need to add anything else soon. So, you'll have to manually remerge it once it hits the mirrors |
