| Summary: | init script install_qa_check not strict enough | ||
|---|---|---|---|
| Product: | Portage Development | Reporter: | Patrick Lauer <patrick> |
| Component: | Core - Ebuild Support | Assignee: | Portage team <dev-portage> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kensington, qa |
| Priority: | Normal | Keywords: | InVCS |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 431026 | ||
The bash --posix option doesn't seem to help. I suppose that we could use dash instead, if it happens to be installed. (In reply to comment #1) > I suppose that we could use dash instead, if it happens to be installed. If you're considering the use of external programs, perhaps dev-util/checkbashisms will be of interest. It's fixed to use checkbashisms when available: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=f48625c547398ee5f92d33e16b1a837c3c595ae9 This is fixed in 2.1.11.31 and 2.2.0_alpha142. |
* Call stack: * misc-functions.sh, line 1274: Called install_qa_check * misc-functions.sh, line 557: Called die * The specific snippet of code: * bash -n "${i}" || die "The init.d file has syntax errors: ${i}" Since init scripts should be posix sh this check may not be strict enough. Bashisms should not be tolerated!