Bug 439184

Summary:	app-emulation/wine (several versions): pulseaudio patchset ignores useflag
Product:	Gentoo Linux	Reporter:	Ramon Klass <tier>
Component:	Current packages	Assignee:	Wine Maintainers <wine>
Status:	RESOLVED INVALID
Severity:	normal	CC:	tier
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	patch to retroactively only patch when the useflag was set

Description Ramon Klass 2012-10-21 16:46:24 UTC

one-liner, but in many ebuilds: the pulseaudio patchset gets applied no matter if use pulseaudio is set or not. Do I misunderstand the purpose of useflags?


Reproducible: Always

Steps to Reproduce:
emerge wine with USE="-pulseaudio"
Actual Results:  
pulseaudio patches get applied either way

Expected Results:  
would have expected the pulseaudio patchset to be left out depending on use

Comment 1 Ramon Klass 2012-10-21 16:48:20 UTC

Created attachment 327088 [details, diff]
patch to retroactively only patch when the useflag was set

Comment 2 Jeroen Roovers (RETIRED) gentoo-dev

2012-10-22 04:59:14 UTC

Comment on attachment 327088 [details, diff]
patch to retroactively only patch when the useflag was set

All patches should ideally apply generally (not conditionally) and add changes to the source that work out configuring specifically for the feature or enhancement that is being added.

Comment 3 SpanKY gentoo-dev

2012-10-22 19:58:47 UTC

(In reply to comment #2)

more specifically, applying the patch does not itself enable pulseaudio support.  only the configure flag (which is controlled by the USE flag) later on enables support.