Bug 438240 – net-irc/irker - several issues

• Product: Gentoo Linux
• Status: RESOLVED OBSOLETE

[Description Laurent Bachelier 2012-10-13 16:11:02 UTC]

- irkerhook is installed in /usr/bin/ but it should not be started by the user directly, so it would be better in /usr/libexec
- irk is not installed (and should be in /usr/bin)
- I'm not sure how the init.d script can work as of now since irkerd does not create a pid file and start-stop-daemon is not told to
- there is a systemd service distributed, but it is not installed
- shebangs are not translated, in case python2 is not the default interpreter
- there are a lot of unnecessary die() since it is EAPI 4
- a lot of documentation is not installed
- irkerd is run as root by the init script
- it won't install in some setups because xmlto will try to make network requests to validate the XML files

All of this is actually correctly handled in my older ebuild available at https://git.p.engu.in/laurentb/gentoo-overlay/tree/dev-vcs/irker

Also, python-irclib was updated, yet its module name is different and pretty much incompatible; I renamed it to dev-python/irc.

[Comment 1 Laurent Bachelier 2012-11-06 18:13:46 UTC]

Some things have been fixed, however irker is now known not to work with dev-python/irc-3.4.2 (or anything newer than 3.2.3).

[Comment 2 Laurent Bachelier 2012-11-06 18:15:18 UTC]

New URL for my ebuild: http://git.p.engu.in/laurentb/gentoo-overlay/tree/net-irc/irker

[Comment 3 Bertrand Jacquin 2013-09-19 13:52:43 UTC]

Created attachment 359018 [details, diff]
irker-1.20.ebuild-cleanup.diff

Cleanup to irker-1.20.ebuild :
 - Migration to EAPI 5
 - Migration to python-single-r1
 - Split globlal var definition for more visibility
 - Don't use Makefile SYSTEMD detection system, but use systemd eclass
 - Prefix support
 - Docs and examples

[Comment 4 Bertrand Jacquin 2013-09-19 13:53:16 UTC]

Created attachment 359020 [details]
irker-1.20.ebuild

plain ebuild

[Comment 5 Bertrand Jacquin 2013-09-19 13:54:58 UTC]

Created attachment 359022 [details]
files/irkerd.initd

Review init.d to use more generic runscript syntax and to run as 'nobody' by default.

Is there any need to a dedicated user ?

[Comment 6 Bertrand Jacquin 2013-09-19 13:55:55 UTC]

Created attachment 359024 [details]
files/irkerd.conf

Adapt conf.d since files/irkerd.initd can change username

[Comment 7 Bertrand Jacquin 2013-09-19 13:57:25 UTC]

This bug should block 332633 as /var/run is still in use in upstream ebuild

[Comment 8 Laurent Bachelier 2013-10-01 19:30:45 UTC]

(In reply to Bertrand Jacquin from comment #5)
> Is there any need to a dedicated user ?

"nobody" user should be OK, it only needs network permissions.

[Comment 9 Bertrand Jacquin 2013-10-05 17:07:17 UTC]

Created attachment 360158 [details, diff]
files/0001-Register-author_name-as-author-instead-of-email-user.patch

Register author_name as author instead of email userpart

[Comment 10 Bertrand Jacquin 2013-10-05 17:08:33 UTC]

Created attachment 360160 [details, diff]
irker-1.20.ebuild-cleanup.diff

[Comment 11 Bertrand Jacquin 2013-10-05 17:11:00 UTC]

Created attachment 360164 [details]
irker-1.20.ebuild

irker-1.20.ebuild v3

 - Migration to EAPI 5
 - Migration to python-single-r1
 - Split global var definition for more visibility
 - Don't use Makefile SYSTEMD detection system, but use systemd eclass
 - Prefix support
 - Docs and examples
 - Patch to send author_name instead of email user part
 - Install irk

[Comment 12 Bertrand Jacquin 2013-10-05 17:12:50 UTC]

Created attachment 360166 [details]
irker-1.20.ebuild

irker-1.20.ebuild v3

 - Migration to EAPI 5
 - Migration to python-single-r1
 - Split global var definition for more visibility
 - Don't use Makefile SYSTEMD detection system, but use systemd eclass
 - Prefix support
 - Docs and examples
 - Patch to send author_name instead of email user part
 - Install irk

[Comment 13 Bertrand Jacquin 2013-10-05 17:14:59 UTC]

Created attachment 360168 [details]
files/irkerd.initd

files/irkerd.initd v3

 - Migrate to /run
 - run as 'nobody' by default
 - Define all supported irkerd options to confd, this eas the logfile and loglevel handling
 - create logfile with correct permissions
 - close stdin (in a bad way as ssd don't work as expected)

[Comment 14 Bertrand Jacquin 2013-10-05 17:15:43 UTC]

Created attachment 360170 [details]
files/irkerd.confd

[Comment 15 Bertrand Jacquin 2013-10-05 17:35:52 UTC]

Created attachment 360172 [details, diff]
files/0002-Fixed-utf-8-handling-in-metadata.patch

Include @tasn patchset from git://gitorious.org/irker/irker.git

Tom Hacohen (2):      
  Fixed utf-8 handling in metadata.       
  Git: Fixed presentation of branches containing front-slashes.

[Comment 16 Bertrand Jacquin 2013-10-05 17:36:07 UTC]

Created attachment 360174 [details, diff]
files/0003-Git-Fixed-presentation-of-branches-containing-front-.patch

Include @tasn patchset from git://gitorious.org/irker/irker.git

Tom Hacohen (2):      
  Fixed utf-8 handling in metadata.       
  Git: Fixed presentation of branches containing front-slashes.

[Comment 17 Bertrand Jacquin 2013-10-05 17:37:37 UTC]

Created attachment 360176 [details, diff]
irker-1.20.ebuild-cleanup.diff

[Comment 18 Bertrand Jacquin 2013-10-05 17:40:00 UTC]

Created attachment 360178 [details]
irker-1.20.ebuild

irker-1.20.ebuild v4

 - Migration to EAPI 5
 - Migration to python-single-r1
 - Split global var definition for more visibility
 - Don't use Makefile SYSTEMD detection system, but use systemd eclass
 - Prefix support
 - Docs and examples
 - Install irk
 - Patch to send author_name instead of email user part (https://gitorious.org/irker/irker/merge_requests/25)
 - Patch to fix UTF-8 handling ( https://gitorious.org/irker/irker/merge_requests/23)
 - Patch to fix branche presentation (https://gitorious.org/irker/irker/merge_requests/24)

[Comment 19 Patrick Lauer 2014-06-12 03:16:25 UTC]

2.9 now in tree, not sure if anything from this bug is still relevant.