Bug 436920

Summary:	sci-electronics/smartsim: new ebuild
Product:	Gentoo Linux	Reporter:	Denilson Sá Maia <denilsonsa>
Component:	New packages	Assignee:	Default Assignee for New Packages <maintainer-wanted>
Status:	UNCONFIRMED ---
Severity:	enhancement	CC:	sci
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	smartsim-9999.ebuild smartsim-9999.ebuild

Description Denilson Sá Maia 2012-10-02 04:17:18 UTC

Created attachment 325514 [details]
smartsim-9999.ebuild

New ebuild:
sci-electronics/smartsim-9999
SmartSim is digital logic circuit design and simulation package
http://www.smartsim.org.uk/
https://github.com/ashleynewson/SmartSim

This ebuild grabs directly from github. Versioned ebuilds should be easy, if upstream starts providing versioned tarballs or git tags.

Comment 1 SpanKY gentoo-dev

2012-10-02 04:47:24 UTC

Comment on attachment 325514 [details]
smartsim-9999.ebuild

>DESCRIPTION="SmartSim is digital logic circuit design and simulation package"

drop the "smartsim is"

>SRC_URI="doc? (
>	http://www.smartsim.org.uk/downloads/manual/smartsim_user_manual.pdf )"

don't line wrap it

>EGIT_REPO_URI="git://github.com/ashleynewson/SmartSim.git
>	https://github.com/ashleynewson/SmartSim.git"

just list the git:// and this should be above the inherit

>KEYWORDS="~amd64"

live ebuilds should not have keywords.  set this to "".

>DEPEND="dev-libs/libxml2:2
>	dev-util/pkgconfig

use virtual/pkgconfig.  this should not be in RDEPEND btw, so initialize RDEPEND with all the right things, then set DEPEND to $RDEPEND plus pkgconfig.

>src_install() {
>	emake DESTDIR="${D}" install || die "Install failed"
>	dodoc AUTHORS ChangeLog NEWS README || die

replace with `default`

>	if use doc; then
>		insinto /usr/share/doc/${PF}
>		doins "${DISTDIR}"/smartsim_user_manual.pdf

use doc && dodoc "${DISTDIR}"/smartsim_user_manual.pdf

Comment 2 Denilson Sá Maia 2012-10-03 05:26:27 UTC

Created attachment 325566 [details]
smartsim-9999.ebuild

> this should not be in RDEPEND btw, so initialize RDEPEND with
> all the right things, then set DEPEND to $RDEPEND plus pkgconfig.

I totally agree, but unfortunately the ebuild template for Vim automatically puts RDEPEND="${DEPEND}". (how to reproduce: run "vim foobar.ebuild", maybe we should open a bug about this)

> >src_install() {
> >	emake DESTDIR="${D}" install || die "Install failed"
> >	dodoc AUTHORS ChangeLog NEWS README || die
> 
> replace with `default`

It's been so long since the last time I wrote an ebuild that I didn't know about this "default" command!