Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 435780

Summary: media-gfx/optipng-0.7.3 calls gcc, ar, ranlib directly
Product: Gentoo Linux Reporter: Agostino Sarubbo <ago>
Component: New packagesAssignee: Sebastian Pipping <sping>
Severity: normal CC: tristan
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 243502    
Attachments: patch

Description Agostino Sarubbo gentoo-dev 2012-09-21 19:23:37 UTC
Created attachment 324530 [details, diff]

ar cru libpnmio.a pnmin.o pnmout.o pnmutil.o
ranlib libpnmio.a
make[1]: Leaving directory `/tmp/portage/media-gfx/optipng-0.7.3/work/optipng-0.7.3/src/pnmio'
ar cru libopngreduc.a opngreduc.o

gcc is called directly only in the function src_test() :

>>> Source compiled.
>>> Test phase [check]: media-gfx/optipng-0.7.3
cd src/optipng && \
make test && \
cd ../..
make[1]: Entering directory `/tmp/portage/media-gfx/optipng-0.7.3/work/optipng-0.7.3/src/optipng'
gcc -c -I.  -march=native -O2 -g0 -o test/cbitset_test.o test/cbitset_test.c
gcc -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -o test/cbitset_test \
  test/cbitset_test.o cbitset.o 

The attached patch will solve this issue and bump to eapi4
Comment 1 Sebastian Pipping gentoo-dev 2012-09-22 20:44:47 UTC
Patch looks excellent, thank you!

Since 0.7.3 is stable by now, I made 0.7.3-r1 despite equal -- I assume -- compilation results.

+*optipng-0.7.3-r1 (22 Sep 2012)
+  22 Sep 2012; Sebastian Pipping <> +optipng-0.7.3-r1.ebuild:
+  No longer calls gcc, ar, ranlib directly (bug #435780), patch by Agostino