Summary: | x11-libs/libfm - Add 'vala' use flag | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Mr. B <tenebrarum> |
Component: | New packages | Assignee: | Markos Chandras (RETIRED) <hwoarang> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | dominique.c.michel, lxde+disabled |
Priority: | Low | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
1.0 ebuild patch
live ebuild patch flag descriptions |
Description
Mr. B
2012-09-18 14:30:35 UTC
Created attachment 324202 [details, diff]
1.0 ebuild patch
Created attachment 324204 [details, diff]
live ebuild patch
Created attachment 324206 [details, diff]
flag descriptions
Sorry, I can't accept the udisks patch. See http://sourceforge.net/tracker/index.php?func=detail&aid=3531655&group_id=156956&atid=801864 . Also, you could have spotted that if you have looked at the ebuild Changelog ;) So we must always build with udisks disable (which is the default configuration) I see if the 'vala' patch is appropriate. (In reply to comment #4) > Sorry, I can't accept the udisks patch. See > > http://sourceforge.net/tracker/index. > php?func=detail&aid=3531655&group_id=156956&atid=801864 . Also, you could > have spotted that if you have looked at the ebuild Changelog ;) > > So we must always build with udisks disable (which is the default > configuration) Oh, sorry ... shouldn't the udisk dependencies be removed then? I was wrong but now that I am in front of my PC I see what is going on So udisks is enabled by default. --enable-udisks build libfm with udisks support (Linux only) [default=yes] however, if you disable udisks, udev kicks in and this is what it is broken. So we must always build with udisks support. This is why it is not controlled by a use flag The 'vala' use flag is now present in 1.0.1 and 9999. Thanks for reporting *** Bug 438478 has been marked as a duplicate of this bug. *** What do you mean by "udev kicks in and this is what it is broken"? I installed lxde without udisk support, I start it with startx. When I plug-in an USB disk, if it is configured in /etc/fstab, it just get mounted at the defined mount point, that without user involment. If not defined in /etc/fstab, it is mounted in /media/*, that without user intervention. In both cases, I can umount them with umount, pmount or pmount-gui. I just cannot dream of a better system for that. The same for the cd/dvd, they just get mounted or umounted when I insert or eject them. And this is fine. It is evident for me, when I insert a dvd, that I want to access it. So for me, nothing is broken, and my system is just working like I want it to be working. Yes, udev kicks in and mount the devices. And yes, it is exactly what udev was made for and how I use it. This is why I just have no use for *kit and Co, they are just pure sabotage of my setup for me, and why I just don't want them. Or, if the problem is somewhere else, please be more specific so I can understand it. Read the upstream bug report. Upstream developer says that udisks support (aka udev) is broken ok? Doesn't libfm work as it is now? It seems to work for everyone else (including me). If it doesn't then udisks is not the problem then (as it is disabled). (In reply to comment #10) > Read the upstream bug report. Upstream developer says that udisks support > (aka udev) is broken ok? The upstream bug report say: Status: Closed Resolution: Works For Me And also, if you read https://bugs.gentoo.org/show_bug.cgi?id=438478 you will see that in lxsession, I keep the udev USE flag and add an udisks flag. udev and udisks are not the same. Reviewing my patch for libfm https://bugs.gentoo.org/attachment.cgi?id=326620&action=diff, 2 things are wrong. 1) In portage ebuild: RDEPEND="${COMMON_DEPEND} || ( gnome-base/gvfs[udev,udisks] gnome-base/gvfs[udev,gdu] )" This will force the installation of udisks and polkit. --disable-udisks \ udisks is disabled when configuring. This imply this is no need to install udisks and polkit. You can reopen this bug in all cases. 2) in my patch: --disable-udisks \ ... $(use_enable udisks) \ $(use_enable udisks) will take the precedence, but --disable-udisks must be removed. Let me read the upstream bug report for you since you seem to not understand what I am taking about: (Note, this is what the upstream developer says) "The udisks support is experimental and is not stable. The author of udisks already abandons udisks and is now making udisks2 which is very different. So I won't fix udisks support now since it's a waste of time. When I finally finish it, they drop udisks again and I need to do it again from scratch for udisks2. So sad. :-( Please turn off udisks support for now." So, udisks support will remain disabled in libfm. As for the lxsession, I will have to reconsider that. (In reply to comment #13) > > So, udisks support will remain disabled in libfm. That's fine for me. But please, remove or comment out the dependency on udisks if it is disabled. With portage ebuild, I get: # emerge -vp =libfm-1.0.1 These are the packages that would be merged, in order: Calculating dependencies... done! [ebuild N ] sys-apps/gptfdisk-0.8.5 0 kB [ebuild N ] dev-libs/libatasmart-0.19 USE="-static-libs" 0 kB [ebuild N ] sys-fs/cryptsetup-1.4.3 USE="nls (-selinux) -static -static-libs" 0 kB [ebuild N #] sys-auth/polkit-0.107-r1 USE="gtk introspection nls pam -examples -kde (-selinux) -systemd" 0 kB [ebuild N ] sys-auth/consolekit-0.4.5_p20120320-r1 USE="acl pam policykit -debug -doc (-selinux) {-test}" 0 kB [ebuild N ] gnome-extra/polkit-gnome-0.105 0 kB [ebuild R ] sys-auth/pambase-20120417-r1 USE="consolekit* cracklib sha512 -debug -gnome-keyring -minimal -mktemp -pam_krb5 -pam_ssh -passwdqc (-selinux) -systemd" 0 kB [ebuild N ] sys-fs/udisks-2.0.0 USE="crypt gptfdisk introspection -debug -systemd" 730 kB [ebuild R ] gnome-base/gvfs-1.12.3-r1 USE="archive avahi bluetooth cdda fuse gnome-keyring gphoto2 http udev udisks* -afp -bluray -doc -gdu -ios -samba" 0 kB [ebuild R ] x11-libs/libfm-1.0.1::gentoo [1.0.1::x-test] USE="vala -debug -doc -examples (-udisks%)" 0 kB Total: 10 packages (7 new, 3 reinstalls), Size of downloads: 730 kB The following mask changes are necessary to proceed: #required by sys-fs/udisks-2.0.0, required by gnome-base/gvfs-1.12.3-r1[udisks], required by x11-libs/libfm-1.0.1, required by @selected, required by @world (argument) # /etc/portage/package.mask: #=dev-scheme/guile-gnome-platform-2.16.1-r1 #=media-sound/snd-ls-0.9.9.2_beta =sys-auth/polkit-0.107-r1 The following USE changes are necessary to proceed: #required by sys-auth/polkit-0.107-r1[-systemd], required by gnome-extra/polkit-gnome-0.105 >=sys-auth/consolekit-0.4.5_p20120320-r1 policykit #required by x11-libs/libfm-1.0.1, required by @selected, required by @world (argument) =gnome-base/gvfs-1.12.3-r1 udisks #required by sys-auth/polkit-0.107-r1[-systemd,pam], required by gnome-extra/polkit-gnome-0.105 >=sys-auth/pambase-20120417-r1 consolekit Also, gvfs is installed in my system, so maybe the right solution would be something like RDEPEND="${COMMON_DEPEND} || ( gnome-base/gvfs[udev] gnome-base/gvfs[udev] )" ############ Also, a live ebuild install experimental code. So, I would add a udisks USE flag in it. But again, I don't want udisk, so it is fine for me if you just remove or comment out the depend. > > As for the lxsession, I will have to reconsider that. BTW, the right use flag to add will be upower, and not udisks.
>
> Also, gvfs is installed in my system, so maybe the right solution would be
> something like
>
> RDEPEND="${COMMON_DEPEND}
> || ( gnome-base/gvfs[udev] gnome-base/gvfs[udev] )"
>
I dont understand this line. it is the same thing twice isnt it? unfortunately i cant remove the udisks dependency on gvfs. libfm requires gvfs *with* udisks support but libfm cant use udisks directly. it has to go through the gvfs
(In reply to comment #15) > > > > Also, gvfs is installed in my system, so maybe the right solution would be > > something like > > > > RDEPEND="${COMMON_DEPEND} > > || ( gnome-base/gvfs[udev] gnome-base/gvfs[udev] )" > > > I dont understand this line. it is the same thing twice isnt it? > unfortunately i cant remove the udisks dependency on gvfs. libfm requires > gvfs *with* udisks support but libfm cant use udisks directly. it has to go > through the gvfs Yes, you are right. The correct one should be RDEPEND="${COMMON_DEPEND} gnome-base/gvfs[udev] gnome-base/gvfs[udev] )" > > Sorry, wrong manip. RDEPEND="${COMMON_DEPEND} gnome-base/gvfs[udev]" (In reply to comment #15) > unfortunately i cant remove the udisks dependency on gvfs. libfm requires > gvfs *with* udisks support but libfm cant use udisks directly. it has to go > through the gvfs I use libfm here without udisks support in gvfs and it work fine: # emerge -vp gvfs These are the packages that would be merged, in order: Calculating dependencies... done! [ebuild R ] gnome-base/gvfs-1.12.3-r1 USE="archive avahi bluetooth cdda fuse gnome-keyring gphoto2 http udev -afp -bluray -doc -gdu -ios -samba -udisks" In pcmanfm, in its right panel, the removable disks get updated when I insert or remove/unmount them. (In reply to comment #18) > (In reply to comment #15) > > > unfortunately i cant remove the udisks dependency on gvfs. libfm requires > > gvfs *with* udisks support but libfm cant use udisks directly. it has to go > > through the gvfs > > I use libfm here without udisks support in gvfs and it work fine: > > # emerge -vp gvfs > > These are the packages that would be merged, in order: > > Calculating dependencies... done! > [ebuild R ] gnome-base/gvfs-1.12.3-r1 USE="archive avahi bluetooth > cdda fuse gnome-keyring gphoto2 http udev -afp -bluray -doc -gdu -ios -samba > -udisks" > > In pcmanfm, in its right panel, the removable disks get updated when I > insert or remove/unmount them. Hmm that needs investigation. Could you open a new bug so we can keep a clean track of it? It is bug 438700 |