Bug 434824

Summary:	sys-power/powertop-2.1-r1 - false positive kernel config check
Product:	Gentoo Linux	Reporter:	David Philippi <gentoo>
Component:	New packages	Assignee:	Mobile Herd (OBSOLETE) <mobile+disabled>
Status:	RESOLVED INVALID
Severity:	trivial	CC:	zerochaos
Priority:	Normal
Version:	2006.0
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description David Philippi 2012-09-12 13:16:48 UTC

* Checking for suitable kernel configuration options...
 *   CONFIG_SND_HDA_POWER_SAVE:  is not set when it should be.

This is a false positive. The power save mode is not activated because the whole driver is missing as I don't have the hardware.
Without compiling the driver, I can't activate its powersave feature either.

Doesn't matter too much, but I spend some time searching as I didn't catch that HDA means high definition audio and expected to miss a more generic sound card powersave feature.

Reproducible: Always

Comment 1 Rick Farina (Zero_Chaos) gentoo-dev

2012-09-14 13:41:11 UTC

Powertop requests that this feature is turned on, if you don't want to turn it on that is why it is a warning not an error.

Comment 2 David Philippi 2012-09-14 13:53:03 UTC

You misunderstood the report I think.

Powertop may request this feature to be turned on, yes. But it only makes any kind of sense to turn this feature on if the hardware is existant in the system. If the kernel options don't set support for the hardware, neither powertop nor the ebuild should request the power saving feature for it to be turned on.

In order to turn on the feature, I'd have to configure the kernel to compile a driver for hardware I don't own. Otherwise I can't set it.

Comment 3 Rick Farina (Zero_Chaos) gentoo-dev

2012-09-14 14:04:24 UTC

I understand fine, however, I can't check in the ebuild if you have the hardware or not.  Powertop's readme says it REQUIRES the option, I realize not everyone has the hardware, so I made it a warning. It says it might not run as expected right, well for you it does, so enjoy.

Comment 4 David Philippi 2012-09-14 14:18:41 UTC

You can easily check it in the same way as you check for that option. If the option for the hardware is not set, skip the check for the powersave feature on it.

Powertop doesn't print any kind of warning/errors either.