Bug 434800

Summary:	sys-apps/openrc-0.10.5: [RC_PARALLEL] flock() failed: Interrupted system call
Product:	Gentoo Linux	Reporter:	Pacho Ramos <pacho>
Component:	[OLD] Core system	Assignee:	OpenRC Team <openrc>
Status:	RESOLVED FIXED
Severity:	normal	CC:	b+bugs.gentoo.org, e.suarezsantana, goeri.georg
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	439098
Attachments:	rc.conf Patch - retry flock if it was interrupted by signal

Description Pacho Ramos gentoo-dev

2012-09-12 07:08:11 UTC

Since I updated to it for testing latest udev versions I sometimes get messages like:
flock() failed: Interrupted system call

when trying to start some service, the problem is that it occurs in a random way, sometimes it boots without showing it, others it's shown for a service, others for other service and, the most strange thing, it looks like service is correctly started anyway even if the message is shown.

But this is clearly a regression over current stable 0.9.8.4

Portage 2.1.11.14 (default/linux/amd64/10.0/desktop/gnome, gcc-4.5.4, glibc-2.15-r2, 3.5.3-gentoo x86_64)
=================================================================
System uname: Linux-3.5.3-gentoo-x86_64-Intel-R-_Core-TM-_i5-2410M_CPU_@_2.30GHz-with-gentoo-2.1
Timestamp of tree: Tue, 11 Sep 2012 18:00:01 +0000
ccache version 3.1.7 [enabled]
app-shells/bash:          4.2_p37
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.3-r2, 3.2.3
dev-util/ccache:          3.1.7
dev-util/cmake:           2.8.8-r3
dev-util/pkgconfig:       0.27.1
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.10.5
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.9.6-r3, 1.10.3, 1.11.6, 1.12.1
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.4.7, 4.5.4
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r3
sys-kernel/linux-headers: 3.4-r2 (virtual/os-headers)
sys-libs/glibc:           2.15-r2
Repositories: gentoo bumblebee x11 x-portage
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native"
DISTDIR="/usr/distfiles"
EMERGE_DEFAULT_OPTS="--quiet-build=n --autounmask-write"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs ccache config-protect-if-modified distlocks ebuild-locks fixlafiles multilib-strict news parallel-fetch protect-owned sandbox sfperms sign split-log strict test test-fail-continue unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.ovh.net/gentoo-distfiles/ http://ftp.heanet.ie/pub/gentoo/"
LANG="es_ES.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
LINGUAS="es es_ES en_US"
MAKEOPTS="-j5"
PKGDIR="/usr/local/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/bumblebee /usr/portage/local/layman/x11 /usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa amd64 applet bash-completion berkdb bluetooth branding bzip2 cairo cdda cddb cdr cli colord consolekit cracklib crypt cups cvs cxx dbus djvu dri dts dvd dvdr dvi eds emboss enchant encode evo exif fam fat ffmpeg firefox flac fortran fuse gdbm gif gnome gnome-keyring gnome-online-accounts gpm gstreamer gtk gtk3 gtkstyle http iconv jpeg kpathsea latex lcms ldap libnotify libvisual lyx mad mms mmx mmxext mng modules mono monolithic-build mp3 mp4 mpeg mudflap multilib musicbrainz nautilus ncurses network-cron networkmanager nls nptl ntfs ntp numa nvidia ogg opengl openmp optimized-qmake pam pango pch pdf png policykit ppds pppd pulseaudio qt3support readline reiserfs scanner sdl session smp sna socialweb spell sse sse2 sse3 ssl ssse3 startup-notification svg t1lib tcpd test theora threads tiff truetype udev udisks unicode upower usb v4l vaapi vcd vdpau vorbis wifi wxwidgets x264 xcb xfs xml xv xvid youtube zlib" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="es es_ES en_US" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="fbdev nvidia vesa intel i915 i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON


Reproducible: Always

Comment 1 Pacho Ramos gentoo-dev

2012-09-12 07:08:24 UTC

Created attachment 323578 [details]
rc.conf

Comment 2 Timothy Messier 2012-11-24 16:22:24 UTC

Also happens for sys-apps/openrc-0.11.5 (which recently became marked as stable for amd64)

Comment 3 Alexander Mezin 2013-01-31 06:50:46 UTC

Created attachment 337382 [details, diff]
Patch - retry flock if it was interrupted by signal

Comment 4 Alexander Mezin 2013-02-02 12:26:04 UTC

I'm sure that failing on any signal was not expected behavior.

Rebooted many times with patched openrc, had no problems. Now, I don't see any error messages, and text isn't messed up.

Comment 5 Alexander Mezin 2013-02-13 23:23:34 UTC

Sorry, but why this still isn't fixed?
This bug isn't as important as crashing, but is very annoying.
I can provide additional comments, if this will speed up the process:

This bug is introduced by this commit:
http://git.overlays.gentoo.org/gitweb/?p=proj/openrc.git;a=commit;h=6be8a0679b8d64ea5b99ea98839eab2ce129988b

This part of commit message is wrong: "flock() would simply block till a previous lock has been released". flock() will also fail when any signal arrives, as almost all blocking calls will do. So when flock() failed with errno==EINTR, we should try again. This won't return bug #360013.

I use patched openrc since my first message here, and I didn't find any regressions, only improvements.

Comment 6 William Hubbs gentoo-dev

2013-02-15 19:38:00 UTC

This has been applied in commit 970893a and will be part of openrc-0.12.
Thanks for the report, and sorry this took so long to apply.