Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 434704

Summary: x11-misc/matchbox-keyboard-0.1: QA Notice: This package installs one or more .desktop files that do not pass validation.
Product: Gentoo Linux Reporter: Ilya Gordeev <mirraz1>
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED FIXED    
Severity: QA CC: popham, proxy-maint
Priority: Low    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 444206    
Attachments: Fix QA warnings
Fix QA warnings and move to EAPI 6
Fix QA notices and migrate to EAPI6

Description Ilya Gordeev 2012-09-11 08:54:37 UTC
QA Notice: This package installs one or more .desktop files that do not
pass validation.

        /usr/share/applications/inputmethods/matchbox-keyboard.desktop: error: (will be fatal in the future): value "matchbox-keyboard.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path
        /usr/share/applications/inputmethods/matchbox-keyboard.desktop: error: value "Panel;Utility;MB" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character

Reproducible: Always
Comment 1 popham 2016-01-30 10:11:44 UTC
Created attachment 424224 [details, diff]
Fix QA warnings

Prefixing custom categories with `X-` to appease the quality checker.  I expect that the other matchbox stuff will require analogous updating for compatibility.  The other matchbox stuff (including matchbox-keyboard itself) are scheduled for removal on 2-6-2016 (https://bugs.gentoo.org/show_bug.cgi?id=560482), though, so if matchbox-keyboard is the sole survivor of the removal, then the patch will be fine.
Comment 2 popham 2016-02-10 20:48:32 UTC
Created attachment 425170 [details, diff]
Fix QA warnings and move to EAPI 6

Modernizing the matchbox-keyboard to EAPI 6 without QA warnings.  Thanks to wraeth for coddling me through the ebuild nuances.
Comment 3 popham 2016-02-10 22:58:22 UTC
Created attachment 425174 [details, diff]
Fix QA notices and migrate to EAPI6
Comment 4 Sam Jorna (wraeth) gentoo-dev 2016-03-22 02:29:29 UTC
Tim, are you still interested in proxy-maintaining this package? If not, or if there's no reply on this bug soon, I will commit this to close this bug.

My buildtesting of this has completed without issue and this ebuild looks ready to commit - good work!

If you do still wish to proxy-maintain this, please let me know and we will get it committed.

Thanks!
Comment 5 Sam Jorna (wraeth) gentoo-dev 2016-03-28 07:35:35 UTC
I have commited this fix but, with a lack of confirmation, have not yet assigned a maintainer. If you wish to take maintainership, can you let us know either with a bug or in the IRC channel?

Thanks for your contribution so far!

commit 3c3d1cc6567130ca788e17b9b02daa268f46e52e
Author: Sam Jorna <wraeth@gentoo.org>
Date:   Mon Mar 28 18:32:05 2016 +1100

    x11-misc/matchbox-keyboard: fix .desktop qa warn

    Patches desktop file to resolve QA warning, bump to EAPI6. Ebuild and
    patch from user popham to resolve bug.

    Gentoo-bug: 434704
    Package-Manager: portage-2.2.28