Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 433956

Summary: dev-qt/qtsvg:5 should have an opengl USE flag
Product: Gentoo Linux Reporter: wbrana
Component: [OLD] LibraryAssignee: Qt Bug Alias <qt>
Status: RESOLVED FIXED    
Severity: normal CC: kripton, uwelk
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 454132    

Description wbrana 2012-09-04 19:17:01 UTC
=x11-libs/qt-(widgets|svg)-5.0.0_beta1 are missing USE flag opengl
Comment 1 Davide Pesavento gentoo-dev 2012-09-05 08:50:26 UTC
Would you like to explain *why* you think the flag is missing?
Comment 2 wbrana 2012-09-05 08:56:26 UTC
qt-gui has flag opengl, which disables opengl
qt-(widgets|svg) are using opengl and can't be disabled because of missing flag opengl
Comment 3 Davide Pesavento gentoo-dev 2012-09-05 09:05:32 UTC
Sorry I don't follow... are you saying that qt-{widgets,svg} should have "opengl" in IUSE? Or that they should depend on "qt-gui[opengl]"?
Comment 4 wbrana 2012-09-05 09:20:52 UTC
[ebuild   R    ] x11-libs/qt-gui-5.0.0_beta1::qt  USE="accessibility c++11 glib jpeg pch png xcb -debug -egl -eglfs -evdev -gif -gles2 -kms -opengl -test -udev" 0 kB
[ebuild   R    ] x11-libs/qt-widgets-5.0.0_beta1::qt  USE="accessibility c++11 pch -debug -test" 0 kB
[ebuild   R    ] x11-libs/qt-svg-5.0.0_beta1::qt  USE="c++11 -debug -test" 0 kB
qt-gui has opengl use flag
qt-(widgets|svg) don't have opengl use flag
qt-(widgets|svg) always use opengl because it can't be disabled because of missing opengl use flag
qt-(widgets|svg) should also have opengl use flag, which can be used to disable opengl
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2012-09-05 10:17:03 UTC
(In reply to comment #3)
> Sorry I don't follow... are you saying that qt-{widgets,svg} should have
> "opengl" in IUSE? Or that they should depend on "qt-gui[opengl]"?

Probably these modules should get an IUSE="opengl" and then depend on qt-gui[opengl=]
Comment 6 Davide Pesavento gentoo-dev 2012-09-05 18:03:35 UTC
Why do you think the absence of opengl USE flag implies that opengl is always enabled?
Comment 7 wbrana 2012-09-05 18:11:25 UTC
files 
/usr/lib64/qt5/pkgconfig/QtWidgets.pc 
/usr/lib64/qt5/pkgconfig/QtSvg.pc
contain
qt_config= ... opengl ....
Libs.private: ... -lGL

build log for qt-widgets 
contains
Configuration ... opengl
OpenGL support ......... yes (Desktop OpenGL)
Comment 8 Davide Pesavento gentoo-dev 2012-09-06 02:02:26 UTC
(In reply to comment #7)
> files 
> /usr/lib64/qt5/pkgconfig/QtWidgets.pc 
> /usr/lib64/qt5/pkgconfig/QtSvg.pc
> contain
> qt_config= ... opengl ....
> Libs.private: ... -lGL
> 

mmm interesting, thanks. I'll look into this.

> build log for qt-widgets 
> contains
> Configuration ... opengl
> OpenGL support ......... yes (Desktop OpenGL)

This is irrelevant.
Comment 9 Davide Pesavento gentoo-dev 2014-09-23 16:42:57 UTC
This has been fixed for qtwidgets.
Comment 10 Michael Palimaka (kensington) gentoo-dev 2014-09-24 12:27:57 UTC
Proposed patch for qtsvg:

--- qtsvg-5.3.2.ebuild
+++ qtsvg-5.3.2.ebuild
@@ -14,12 +14,12 @@
        KEYWORDS="~amd64 ~x86"
 fi
 
-IUSE=""
+IUSE="+opengl"
 
 RDEPEND="
        >=dev-qt/qtcore-${PV}:5[debug=]
-       >=dev-qt/qtgui-${PV}:5[debug=]
-       >=dev-qt/qtwidgets-${PV}:5[debug=]
+       >=dev-qt/qtgui-${PV}:5[debug=,opengl=]
+       >=dev-qt/qtwidgets-${PV}:5[debug=,opengl=]
        sys-libs/zlib
 "
 DEPEND="${RDEPEND}
Comment 11 Davide Pesavento gentoo-dev 2014-09-25 00:00:18 UTC
Actually, I don't think this is relevant for qtsvg. Not anymore at least.

1. I cannot find any opengl usage in qtsvg besides a couple of examples (that we don't support yet).

2. -lGL is probably just a transitive dependency, and appears only in Libs.private, which again is irrelevant for us since we don't support static linking.

Am I missing something?
Comment 12 Michael Palimaka (kensington) gentoo-dev 2014-09-25 11:33:26 UTC
(In reply to Davide Pesavento from comment #11)
> Actually, I don't think this is relevant for qtsvg. Not anymore at least.
> 
> 1. I cannot find any opengl usage in qtsvg besides a couple of examples
> (that we don't support yet).
> 
> 2. -lGL is probably just a transitive dependency, and appears only in
> Libs.private, which again is irrelevant for us since we don't support static
> linking.
> 
> Am I missing something?

Beyond -lGL appearing, I was not able to locate anything else either.
Comment 13 Davide Pesavento gentoo-dev 2014-09-25 12:28:34 UTC
Does -lGL still appear if qtgui/qtwidgets are built with opengl disabled?
Comment 14 Michael Palimaka (kensington) gentoo-dev 2014-09-25 12:29:09 UTC
No, it disappeared in that case.
Comment 15 Davide Pesavento gentoo-dev 2014-09-25 12:46:10 UTC
Good. Then nothing else needs to be done. libGL is an indirect dep, and Libs.private is only relevant when linking statically.