| Summary: | emerge app-text/NaturalDocs-1.52 : request Prefix support | ||
|---|---|---|---|
| Product: | Gentoo/Alt | Reporter: | Raboo Treed <britta_22> |
| Component: | Prefix Support | Assignee: | Gentoo Prefix <prefix> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | britta_22, titanofold |
| Priority: | Normal | Keywords: | NeedPatch |
| Version: | unspecified | ||
| Hardware: | x86 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
patch for NaturalDocs-1.52 so it works in prefix
added ~x86-linux to this one.. Final patch based on Fabians + ~x86-linux KEYWORDS |
||
|
Description
Raboo Treed
2012-08-31 09:39:02 UTC
(In reply to comment #0) > emerge NaturalDocs fail. > NaturalDocs-1.52 > First of I had to add it to etc/portage/package.accept_keywords. Don't > really know why it was masked.. Because it didn't have your KEYWORD. Actually, this ebuild doesn't have any Prefix keywords, so you are using an untested (and unported) package and that is why it failed. Do you have a tip on how I can help with this? Because I have a feeling that this wont be my only bump in the road. Helpers like insinto and dosym handle $EPREFIX transparently, however vars from eclasses often include $EPREFIX, hence we need to strip that when we use them with helpers.
Second, we should of course check locations in our Prefix, and not the host system.
--- NaturalDocs-1.52.ebuild 18 Mar 2012 15:57:13 -0000 1.7
+++ NaturalDocs-1.52.ebuild 29 Sep 2012 14:06:33 -0000
@@ -31,10 +31,10 @@
dosym /etc/${PN} /usr/share/${PN}/Config
perlinfo
- insinto ${VENDOR_LIB}
+ insinto ${VENDOR_LIB#${EPREFIX}}
doins -r Modules/NaturalDocs
dodir /usr/share/${PN}/Modules
- dosym ${VENDOR_LIB}/NaturalDocs /usr/share/${PN}/Modules/NaturalDocs
+ dosym ${VENDOR_LIB#${EPREFIX}}/NaturalDocs /usr/share/${PN}/Modules/NaturalDocs
exeinto /usr/share/${PN}
doexe ${PN}
@@ -49,7 +49,7 @@
}
pkg_preinst() {
- if [[ -e /usr/share/${PN}/Config && ! -L /usr/share/${PN}/Config ]] ; then
+ if [[ -e ${EPREFIX}/usr/share/${PN}/Config && ! -L ${EPREFIX}/usr/share/${PN}/Config ]] ; then
mkdir -p /etc/${PN}
mv /usr/share/${PN}/Config/* /etc/${PN}/
rm -rf /usr/share/${PN}/Config
Ok Here is the patch:
--- /usr/local/prefix/usr/portage/app-doc/NaturalDocs/NaturalDocs-1.52.ebuild 2012-03-18 19:03:07.000000000 +0300
+++ NaturalDocs-1.52-r1.ebuild 2012-10-09 17:35:51.000000000 +0400
@@ -31,10 +31,10 @@
dosym /etc/${PN} /usr/share/${PN}/Config
perlinfo
- insinto ${VENDOR_LIB}
+ insinto ${VENDOR_LIB#${EPREFIX}}
doins -r Modules/NaturalDocs
dodir /usr/share/${PN}/Modules
- dosym ${VENDOR_LIB}/NaturalDocs /usr/share/${PN}/Modules/NaturalDocs
+ dosym ${VENDOR_LIB#${EPREFIX}}/NaturalDocs /usr/share/${PN}/Modules/NaturalDocs
exeinto /usr/share/${PN}
doexe ${PN}
Created attachment 326094 [details, diff]
patch for NaturalDocs-1.52 so it works in prefix
Added attachment patch for NaturalDocs-1.52 so it works in prefix
I didn't add a ~x86-linux KEYWORDS, should I do that aswell? Created attachment 326164 [details, diff]
added ~x86-linux to this one..
I gave you the patch in comment #3, so why do you ignore it? Basically this is the same..
Just removed
+ if [[ -e ${EPREFIX}/usr/share/${PN}/Config && ! -L ${EPREFIX}/usr/share/${PN}/Config ]] ; then
Because it didn't seem to work.. Not sure why, perhaps because i didn't run ebuild clean...
But it works now.. I can submit a new patch with that as well..
Created attachment 326186 [details, diff]
Final patch based on Fabians + ~x86-linux KEYWORDS
This one is same as Fabians Patch, but i added ~x86-linux keyword since I've tested that it works with ~x86-linux.
I'm sorry, we have to revisit this. Please add the patched ebuild to the main repository. The problem still exists to this date and the patch provided by Raboo Treed solved the issue for me. @Aaron: please review patch from comment #10, ok to commit? |
