Summary: | dev-ruby/facter-1.6.10: fails tests due to new net-tools | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | New packages | Assignee: | Sysadmin Bugs <sysadmin> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bkohler, doug, kbonner, prefix, ruby |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://tinderboxlogs.s3.amazonaws.com/tbamd64.excelsior.flameeyes.eu/dev-ruby%3Afacter-1.6.10%3A20120823-053254.html | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 446954 | ||
Bug Blocks: | 432280 |
Description
Diego Elio Pettenò (RETIRED)
2012-08-23 14:31:59 UTC
Well, net-tools was stabilized and facter now does not produce any network related output, due to this bug. This is with the stable version for both! I just wanted to point out that this bug is about more than just a few failing tests. Anyone using puppet is in for a big surprise when all the network related facts go missing. I will have to mask the new "stable" net-tools version for now. There's an USE flag that enables the old output. We should probably just depend on that. (In reply to comment #2) > There's an USE flag that enables the old output. > > We should probably just depend on that. The old output USE flag does seem not control the location of ifconfig, only it's output format. The issue is that ifconfig has been moved from /sbin to /bin and Puppet/Facter (wrongly) assume that /sbin/ifconfig is the location for all Linux systems. https://github.com/puppetlabs/facter/blob/master/lib/facter/ipaddress.rb#L29 We either need to put a symlink in /sbin for compatibility or file a bug upstream with the facter people. I have just added a dependency on the old net-tools versions that still provide /sbin/ifconfig. Just a stop-gap measure, but at least it is now clear for portage that facter depends on net-tools, and more specifically on which versions. Ok, I've just added facter 1.6.16 with a patch to use the new /bin/ifconfig path on 'Linux'. That seems to fix the test suite. Judging from the actual output of facter (i.e. missing IP address info) we also need the old-output USE flag. @prefix: I'm not sure to what extend you expect facter to work at all, but since this is changed for all 'Linux' systems this may break on your Linux host systems. If that is the case we'll need to look at better fixes. (In reply to comment #5) > @prefix: I'm not sure to what extend you expect facter to work at all, but > since this is changed for all 'Linux' systems this may break on your Linux > host systems. If that is the case we'll need to look at better fixes. net-tools are a problem in Prefix, in particular on non-Linux ;) I think we need to work on getting this 1.6.16 to stable. The current stable 1.6.0 ebuild's dep on old <sys-apps/net-tools-1.60_p20120127084908 is "correct" but not a good situation-- this old net-tools doesn't build against current stable linux-headers-3.6. New bug for this stable request, or not? (In reply to comment #7) > New bug for this stable request, or not? Yes. I've just filed one. |