| Summary: | app-shells/gentoo-bashcomp - proper support for atoms preceded by equal sign in _pkgname() | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jacek Sowiński <mruwek.gentoo> |
| Component: | Current packages | Assignee: | Gentoo Shell Tools project <shell-tools> |
| Status: | CONFIRMED --- | ||
| Severity: | enhancement | CC: | aranea, pacho, rhill |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 437932 | ||
| Bug Blocks: | |||
| Attachments: |
First patch needed to fix support for atoms with 'equal-sign'
Second patch to fix support for atoms with 'equal-sign' Remove unneeded variable |
||
Created attachment 321442 [details, diff]
Second patch to fix support for atoms with 'equal-sign'
Created attachment 321444 [details, diff]
Remove unneeded variable
By the way, in one of my earlier patches already merged into
main tree I forgot to remove one variable, which was created for my own
debug purposes. Here is a patch to get rid of it.
I also noticed that version completion only works when you use the full cat/pkgname form. It'd be nice if it worked with just pkgname as well. |
Created attachment 321440 [details, diff] First patch needed to fix support for atoms with 'equal-sign' Current support for atoms like =some-category/package-1.23-r1 is broken. Those 2 patches are fixing it: 1. Add '=' *automatically* only when completing installed packages (`_pkgname -I`). 2. Don't look for version unless user explicitly wants to do that - check if '=' sign is the first char of the atom. 3. Fix automatic add of '=' in front of the atom - no more duplicated equal signs. I attached 2 patches in the format given by 'git format-patch'.