Summary: | net-analyzer/rrdtool-1.4.5-r1 with dev-util/pkgconf-0.8.5 installs lua bindings into /usr/local/lib/lua/5.1 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Anthony Basile <blueness> |
Component: | [OLD] Development | Assignee: | Richard Yao (RETIRED) <ryao> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jdhore, nenolod, netmon, zerochaos |
Priority: | Normal | Keywords: | Bug |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Make sure at least one space is printted for cflags/libs
Improved patch format for committing to git |
Description
Anthony Basile
![]() Is there any standard to which pkgconfig must conform? (In reply to comment #1) > Is there any standard to which pkgconfig must conform? http://cgit.freedesktop.org/pkg-config/tree/pkg-config-guide.html and http://cgit.freedesktop.org/pkg-config/tree/pkg-config.1 are probably the closest that pkgconfig has to a specification. (In reply to comment #2) > (In reply to comment #1) > > Is there any standard to which pkgconfig must conform? > > http://cgit.freedesktop.org/pkg-config/tree/pkg-config-guide.html and > http://cgit.freedesktop.org/pkg-config/tree/pkg-config.1 are probably the > closest that pkgconfig has to a specification. nod, those are it. pkgconf needs to be fixed to get same result. Created attachment 326492 [details, diff]
Make sure at least one space is printted for cflags/libs
I've looked at all the specific pkg-config database fields and compared pkgconf to pkg-config. Of these, its seems only the following must print out at least one space:
--cflags print required CFLAGS to stdout
--cflags-only-I print required include-dir CFLAGS to stdout
--cflags-only-other print required non-include-dir CFLAGS to stdout
--libs print required linker flags to stdout
--libs-only-L print required LDPATH linker flags to stdout
--libs-only-l print required LIBNAME linker flags to stdout
--libs-only-other print required other linker flags to stdout
Digging through all their linked lists, I came up with a very simple solution. Just make sure at least one space is printed out for any --cflags* or --libs*. This can't go wrong :)
I'll push it upstream.
Created attachment 326506 [details, diff]
Improved patch format for committing to git
Comment on attachment 326506 [details, diff]
Improved patch format for committing to git
jdhore is on devaway, so I will handle this bug.
net-analyzer/rrdtool-1.4.5-r1 fails to build on my system in what is likely another bug. net-analyzer/rrdtool-1.4.7-r1 works perfectly.
This issue appears to have already been fixed in pkgconf 0.8.9. I have committed dev-util/pkgconf-0.8.9 to portage. I will leave this bug open until dev-util/pkgconf-0.8.9 is stabilized.
(In reply to comment #6) > Comment on attachment 326506 [details, diff] [details, diff] > Improved patch format for committing to git > > jdhore is on devaway, so I will handle this bug. > > net-analyzer/rrdtool-1.4.5-r1 fails to build on my system in what is likely > another bug. net-analyzer/rrdtool-1.4.7-r1 works perfectly. > > This issue appears to have already been fixed in pkgconf 0.8.9. I have > committed dev-util/pkgconf-0.8.9 to portage. I will leave this bug open > until dev-util/pkgconf-0.8.9 is stabilized. Hurricane Sandy caused me to get behind on handling bugs. Anyway, bug #443788 has been opened to ahndle stabilization. I am closing this as fixed. |