Bug 428356 – Please (re-)keyword net-print/cups-1.6.2 and newest net-print/cups-filters

• Product: Gentoo Linux
• Status: RESOLVED OBSOLETE

[Description Andreas K. Hüttel 2012-07-27 18:31:03 UTC]

Arches please do. Missing keywords:

~alpha ~amd64-fbsd ~arm ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~sparc-fbsd ~x86-fbsd

[Comment 1 Andreas K. Hüttel 2012-07-27 18:39:42 UTC]

Special note for >> MIPS << and >> SPARC-FBSD <<: 

I will drop cups-1.4 in one week. That is the last version which you have keyworded, and the keyword bug has really been open for a LOONG time. So please, if you still need cups, do something.

[Comment 2 Alexis Ballier 2012-07-27 19:11:17 UTC]

(In reply to comment #1)
> Special note for >> MIPS << and >> SPARC-FBSD <<: 
> 
> I will drop cups-1.4 in one week. That is the last version which you have
> keyworded, and the keyword bug has really been open for a LOONG time. So
> please, if you still need cups, do something.

for sparc-fbsd, see: 
http://archives.gentoo.org/gentoo-dev/msg_0209efc441a7de103f5b1bb98f3e43b5.xml

[Comment 3 Anthony Basile 2012-07-27 23:58:29 UTC]

(In reply to comment #1)
> Special note for >> MIPS << and >> SPARC-FBSD <<: 
> 
> I will drop cups-1.4 in one week. That is the last version which you have
> keyworded, and the keyword bug has really been open for a LOONG time. So
> please, if you still need cups, do something.

mips definitely wants to keep it.  Please don't drop 1.4 until I get to this.  (And I will, I promise!)

[Comment 4 Anthony Basile 2012-07-28 15:38:08 UTC]

Keyword ~mips.  cups and its deps that were keyworded are:

dev-python/testtools-0.9.15 
dev-python/paramiko-1.7.7.1
dev-python/pyftpdlib-0.7.0
dev-python/subunit-0.0.8 
dev-vcs/bzr-2.5.1

net-print/cups-1.6.0
net-print/cups-9999

net-print/cups-filters-1.0.19
net-print/cups-filters-9999

[Comment 5 Markus Meier 2012-08-05 15:42:19 UTC]

~arm keyword restored

[Comment 6 Naohiro Aota 2012-08-08 10:22:22 UTC]

Created attachment 320680 [details]
build.log

Build failure on FreeBSD with:

In file included from filter/pdftopdf/PDFFTrueTypeFont.h:38:0,
                 from filter/pdftopdf/PDFFTrueTypeFont.cxx:38:
filter/pdftopdf/P2POutputStream.h:49:7: error: expected unqualified-id before '!' token
filter/pdftopdf/P2POutputStream.h:49:7: error: expected ')' before '!' token

This is because FreeBSD's stdio.h has

#define putchar(x)      putc(x, stdout)

and

filter/pdftopdf/P2POutputStream.h include stdio.h and have the following line.

int putchar(char c);

Full build log is attached.

[Comment 7 Naohiro Aota 2012-08-08 10:24:09 UTC]

Created attachment 320682 [details, diff]
cups-filters-1.0.20-putchar.patch

This is a sample patch to avoid the above error. It just #undef putchar after #include'ing stdio.h

[Comment 8 Jeroen Roovers (RETIRED) 2012-08-16 17:08:34 UTC]

Marked ~hppa.

[Comment 9 Jeroen Roovers (RETIRED) 2012-08-22 14:54:06 UTC]

I'm sure I had 1.0.20 marked ~hppa.

[Comment 10 Jeroen Roovers (RETIRED) 2012-08-23 00:16:22 UTC]

Marked ~hppa again.

[Comment 11 Naohiro Aota 2012-08-28 07:49:47 UTC]

(In reply to comment #6)
> Created attachment 320680 [details]
> build.log
> 
> Build failure on FreeBSD with:

any comment from maintainer?

[Comment 12 Andreas K. Hüttel 2012-08-30 22:01:40 UTC]

(In reply to comment #7)
> Created attachment 320682 [details, diff] [details, diff]
> cups-filters-1.0.20-putchar.patch
> 
> This is a sample patch to avoid the above error. It just #undef putchar
> after #include'ing stdio.h

Sorry this took so long. Please try 1.0.23-r1, this part of the code has been completely rewritten (patch does not apply anymore, file to be patched does not exist anymore).

[Comment 13 Anthony Basile 2012-09-01 17:46:16 UTC]

Keyword ~ppc

[Comment 14 Naohiro Aota 2012-09-14 15:07:05 UTC]

Created attachment 323772 [details]
build.log with net-print/cups-filters-1.0.23-r1

(In reply to comment #12)
> (In reply to comment #7)
> > Created attachment 320682 [details, diff] [details, diff] [details, diff]
> > cups-filters-1.0.20-putchar.patch
> > 
> > This is a sample patch to avoid the above error. It just #undef putchar
> > after #include'ing stdio.h
> 
> Sorry this took so long. Please try 1.0.23-r1, this part of the code has
> been completely rewritten (patch does not apply anymore, file to be patched
> does not exist anymore).

Still failed with attached failure log.

[Comment 15 Anthony Basile 2012-09-21 09:39:37 UTC]

keyworded ~ppc64

[Comment 16 Anthony Basile 2012-09-21 09:46:33 UTC]

(In reply to comment #15)
> keyworded ~ppc64

oh sorry i should add i only keyworded net-print/cups-9999 and net-print/cups-filters-9999.  i'm hitting the cups-fitlers problem in comment 14.  Re-cc the arches if you want cups-1.6.1 and net-print/cups-filters-1.0.24 looked at again.

[Comment 17 Naohiro Aota 2012-10-04 08:09:11 UTC]

Added x86-fbsd

[Comment 18 Alexis Ballier 2012-11-06 14:01:45 UTC]

amd64-fbsd done

[Comment 19 Agostino Sarubbo 2012-12-19 18:40:57 UTC]

ia64 done

[Comment 20 Andreas K. Hüttel 2013-03-24 00:14:03 UTC]

Please try to catch up here. At some point in the future we'll want to stabilize Cups-1.6, and we at least want to have all keywords beforehand!

[Comment 21 Andreas K. Hüttel 2013-05-03 11:06:15 UTC]

m68k, s390, sh, sparc: I respectfully request you get moving. Now. After all, you'll want to have 1.6 stable at some point too.

If there's a good reason why you cannot keyword, please state it here and I will try to help.

[Comment 22 Andreas K. Hüttel 2013-06-28 21:44:31 UTC]

(In reply to Andreas K. Hüttel from comment #21)
> m68k, s390, sh, sparc: I respectfully request you get moving. Now. After
> all, you'll want to have 1.6 stable at some point too.
> 
> If there's a good reason why you cannot keyword, please state it here and I
> will try to help.

We continue in bug 442926.