Summary: | dev-util/indent keywording request | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Chí-Thanh Christopher Nguyễn <chithanh> |
Component: | [OLD] Keywording and Stabilization | Assignee: | Jeroen Roovers (RETIRED) <jer> |
Status: | RESOLVED WONTFIX | ||
Severity: | enhancement | Keywords: | KEYWORDREQ |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Other | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Chí-Thanh Christopher Nguyễn
2012-07-24 21:53:38 UTC
The configure check will happily use `cat' when indent isn't found, so I doubt this new dep is really necessary. I've hidden indent behind !amd64-fbsd for the time being, until this is resolved one way or the other. with USE="classic egl gallium gles2 nptl shared-glapi xorg" and VIDEO_CARDS="i965 intel" mesa without indent dependency build fine and works too on my T61. USE="indent" adds a lot of Perl dependencies :/ sys-freebsd/freebsd-ubin provides /usr/bin/indent. dev-util/indent is a GNU fork of the original indent, which is used in *BSD. The original indent supports all of the flags used by mesa 8.1, with the exception of -bls: http://cgit.freedesktop.org/mesa/mesa/commit/configure.ac?id=2224fb6047dd96cbc11d7f2093319e5eb49c0b6b In the original indent, -bl/-br determine brace placement for both statements and declarations. GNU ident redefined -bl/-br to only apply to statements. GNU indent then implemented -bls/-brs and -blf/-brf to apply to struct declarations and function declarations respectively. The ~x86-fbsd keyword never should have been in dev-util/indent. It has been dropped from the ebuild. Instead of keywording dev-util/indent, we could modify autotools to distinguish between GNU ident and the original indent, using appropriate options for each. A quicker way of doing this would be to just patch -brs out of the current autotools check when userland_BSD is set, but that is a hack. Bug 428112 was filed regarding the mesa issue. This bug can be closed as mesa will use BSD indent. |