Bug 427156

Summary:	x11-misc/redshift-1.7[-gtk] should not install icons
Product:	Gentoo Linux	Reporter:	Maxim Kammerer <mk>
Component:	Current packages	Assignee:	Sebastian Pipping <sping>
Status:	RESOLVED FIXED
Severity:	minor	CC:	desktop-misc
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Fix conditionals in Makefile.am

Description Maxim Kammerer 2012-07-18 22:08:27 UTC

The icons:
-rw-r--r-- 1 root root 104394 Jul 18 22:04 /usr/share/icons/hicolor/scalable/apps/redshift-status-off.svg
-rw-r--r-- 1 root root  98173 Jul 18 22:04 /usr/share/icons/hicolor/scalable/apps/redshift-status-on.svg
-rw-r--r-- 1 root root  98173 Jul 18 22:04 /usr/share/icons/hicolor/scalable/apps/redshift.svg

only make sense when gtk UI is enabled.

Comment 1 Sebastian Pipping gentoo-dev

2012-07-20 22:26:40 UTC

Created attachment 318766 [details, diff]
Fix conditionals in Makefile.am

It seems overkill at first, but it quickly turned interesting.  As a side effect, the patch fixes a bug with "make dist" that upstream may be interested in.  Attaching a copy of the patch for the curious.


+*redshift-1.7-r1 (20 Jul 2012)
+
+  20 Jul 2012; Sebastian Pipping <sping@gentoo.org> +redshift-1.7-r1.ebuild,
+  +files/redshift-1.7-make-conditionals.patch:
+  No longer install .svg files for USE=-gtk (bug #427156)
+  The patch has been written with upstream in mind.
+

Comment 2 Maxim Kammerer 2012-07-21 17:23:01 UTC

Installs correctly with USE="nls -geoclue -gnome -gtk", thanks!