Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 427030

Summary: net-misc/sks version bump (and it should install an init.d script along with a uid/gid)
Product: Gentoo Linux Reporter: James Cloos <cloos>
Component: Current packagesAssignee: Kristian Fiskerstrand (RETIRED) <k_f>
Status: RESOLVED FIXED    
Severity: enhancement CC: bircoph, emery, k_f, mrueg, petr.pisar, proxy-maint, systemd
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: sks-1.1.4.ebuid
The bdb_stubs patch from 1.1.2 with a few unused lines ommited.
Runscript for the database daemon.
Renscript for the key recon daemon.
Common config for the runscripts.
Systemd service file for the database daemon.
Systemd service file for the key recon daemon.
sks-1.1.4.ebuild
0001_ECC_OID_fix_x86.patch
sks-1.1.4.ebuild
sks-1.1.4.ebuild
sks-1.1.4-ECC_OID_fix_x86.patch
metadata.xml
sks-db.service
sks-recon.service

Description James Cloos 2012-07-17 21:12:12 UTC
The sks ebuild needs some love.

The sks binary is a daemon; it should be installed in usr/sbin, not in usr/bin.

The db dir needs a dodir (deb puts it in /var/lib/sks).

It needs an init script and a uid/gid.
(something like:

start-stop-daemon --start --quiet --user sks:sks --make-pidfile --pidfile /run/sks/sks.pid --chdir /var/lib/sks --exec /usr/sbin/sks -- db  &

should do the trick.)

Incidently, the /usr/bin/sks_build.sh script, as currently installed, expects sks to bin in /usr/sbin and the db in  /var/lib/sks, so that is already correct.

Also, 1.1.3 is out.
Comment 1 James Cloos 2012-07-17 21:25:50 UTC
Woops.  Forgot:

/etc/sks also needs a dodir and example sksconf, membership and mailsync files.

Deb’s mailsync ends with:

┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
┃ # Jonathan McDowell <pgp-keyserver-admin@earth.li> says that having
┃ # his keyserver's address in the Debian package is fine.
┃ pgp-public-keys@the.earth.li
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

Someone with an @gentoo email address should ask to use that address for Gentoo’s default sks/mailsync, too.
Comment 2 Pacho Ramos gentoo-dev 2012-12-20 21:28:30 UTC
This package now lacks an active maintainer, if you want to help please see:
http://my.opera.com/pacho/blog/2012/11/27/about-maintainer-needed
Comment 3 Pacho Ramos gentoo-dev 2012-12-20 21:28:49 UTC
*** Bug 445152 has been marked as a duplicate of this bug. ***
Comment 4 Pacho Ramos gentoo-dev 2012-12-20 21:29:12 UTC
(In reply to comment #3)
> *** Bug 445152 has been marked as a duplicate of this bug. ***

This contains ebuilds
Comment 5 Emery Hemingway 2012-12-21 01:36:53 UTC
Created attachment 332860 [details]
sks-1.1.4.ebuid
Comment 6 Emery Hemingway 2012-12-21 01:38:51 UTC
Created attachment 332862 [details, diff]
The bdb_stubs patch from 1.1.2 with a few unused lines ommited.
Comment 7 Emery Hemingway 2012-12-21 01:39:31 UTC
Created attachment 332864 [details]
Runscript for the database daemon.
Comment 8 Emery Hemingway 2012-12-21 01:39:58 UTC
Created attachment 332866 [details]
Renscript for the key recon daemon.
Comment 9 Emery Hemingway 2012-12-21 01:40:45 UTC
Created attachment 332868 [details]
Common config for the runscripts.
Comment 10 Emery Hemingway 2012-12-21 01:41:44 UTC
Created attachment 332870 [details]
Systemd service file for the database daemon.
Comment 11 Emery Hemingway 2012-12-21 01:42:13 UTC
Created attachment 332872 [details]
Systemd service file for the key recon daemon.
Comment 12 Emery Hemingway 2012-12-21 01:47:07 UTC
There have been reports of Sks-1.1.4 crashing after a while, which I have experienced but it is not consistant for me.
Comment 13 Pacho Ramos gentoo-dev 2012-12-31 18:25:10 UTC
Are you willing to proxy maintain this?
http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml
Comment 14 Emery Hemingway 2012-12-31 21:17:00 UTC
(In reply to comment #13)
> Are you willing to proxy maintain this?
> http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml

I'll need to read up on QA, but sure.
Comment 15 Pacho Ramos gentoo-dev 2012-12-31 21:37:28 UTC
(In reply to comment #14)
> (In reply to comment #13)
> > Are you willing to proxy maintain this?
> > http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml
> 
> I'll need to read up on QA, but sure.

Will CC proxy-maintainers people then
Comment 16 Kristian Fiskerstrand (RETIRED) gentoo-dev 2013-11-14 20:41:54 UTC
Created attachment 363282 [details]
sks-1.1.4.ebuild
Comment 17 Kristian Fiskerstrand (RETIRED) gentoo-dev 2013-11-14 20:42:27 UTC
Created attachment 363284 [details, diff]
0001_ECC_OID_fix_x86.patch
Comment 18 Kristian Fiskerstrand (RETIRED) gentoo-dev 2013-11-14 20:48:26 UTC
Based on the ebuild from Emery Hemingway is a version of the ebuild I use locally that amongst others include a patch for ECC OIDs on x86 (backport from upstream trunk)

Note that I've only uploaded the ebuild and patch to this bug, as the rest of the files from Emery should be the same. The full repo I'm using locally containing the complete set of files (runscripts etc) is available at https://bitbucket.org/kristianf/portage-overlay/src/tip/net-misc/sks?at=default .
Comment 19 Kristian Fiskerstrand (RETIRED) gentoo-dev 2013-11-14 21:20:12 UTC
Created attachment 363294 [details]
sks-1.1.4.ebuild

I accidentaly uploaded the wrong version of the sks-1.1.4.ebuild initially, that still contained a library reference to BDB5.2
Comment 20 Emery Hemingway 2013-11-14 23:27:42 UTC
(In reply to Kristian Fiskerstrand from comment #19)
> Created attachment 363294 [details]
> sks-1.1.4.ebuild

There are a number of problems with this ebuild, please use the repoman utitily and see the #gentoo-sunrise channel for help.
Comment 21 Kristian Fiskerstrand (RETIRED) gentoo-dev 2013-11-15 01:11:44 UTC
Created attachment 363302 [details]
sks-1.1.4.ebuild
Comment 22 Kristian Fiskerstrand (RETIRED) gentoo-dev 2013-11-15 01:12:14 UTC
Created attachment 363304 [details, diff]
sks-1.1.4-ECC_OID_fix_x86.patch
Comment 23 Kristian Fiskerstrand (RETIRED) gentoo-dev 2013-11-15 01:12:33 UTC
Created attachment 363306 [details]
metadata.xml
Comment 24 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-11-15 04:58:41 UTC
@systemd: mrueg requested systemd unit review on IRC.
Comment 25 Pacho Ramos gentoo-dev 2013-11-15 19:47:13 UTC
Any reason for adding:
Nice=10

to the systemd unit? You can also drop "Type=simple" as it's the default ;)
Comment 26 Kristian Fiskerstrand (RETIRED) gentoo-dev 2013-11-15 20:19:31 UTC
Created attachment 363344 [details]
sks-db.service
Comment 27 Kristian Fiskerstrand (RETIRED) gentoo-dev 2013-11-15 20:19:51 UTC
Created attachment 363346 [details]
sks-recon.service
Comment 28 Kristian Fiskerstrand (RETIRED) gentoo-dev 2013-11-15 20:21:13 UTC
There are no upstream requirements for the recon service to run at a non-default nice level. Updated files also remove Type=simple
Comment 29 Pacho Ramos gentoo-dev 2013-11-15 20:22:55 UTC
They look ok for me :)
Comment 30 Emery Hemingway 2013-11-15 20:25:39 UTC
I put the Nice option in the recon unit because the recon daemon isn't expected to do anything in realtime, it just periodically polls other servers for updates.
Comment 31 Manuel Rüger (RETIRED) gentoo-dev 2013-11-22 02:36:34 UTC
Thanks for your help!

*sks-1.1.4 (22 Nov 2013)
 
   22 Nov 2013; Manuel Rüger <mrueg@gentoo.org>
   +files/sks-1.1.4-ECC_OID_fix_x86.patch, +files/sks-db.initd,
   +files/sks-db.service, +files/sks-recon.initd, +files/sks-recon.service,
   +files/sks.confd, +sks-1.1.4.ebuild, metadata.xml:
   Version bump. Add initd scripts and systemd unit files by Emery Hemingway.
   Fixes bug #427030. Add Kristian Fiskerstrand as maintainer and proxy-
   maintainers as herd.