Bug 426398 – net-dialup/pptpclient - stability fixes

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Dirk Olmes 2012-07-13 06:15:40 UTC]

I use pptp to connect to a customer's VPN. This VPN has been somewhat unstable, pptp kept crashing from time to time with a segfault.

Googling around, I came across a couple of stability fixes by the fedora project, see comment #28 in https://bugzilla.redhat.com/show_bug.cgi?id=749455#c28

I incorporated these stability fixes into an ebuild which has been working here for a couple of days without segfaults now. Maybe this helps other users of pptpclient.

[Comment 1 Dirk Olmes 2012-07-13 06:16:18 UTC]

Created attachment 318054 [details]
ebuild incorporating the additional fixes

[Comment 2 Dirk Olmes 2012-07-13 06:17:55 UTC]

Created attachment 318056 [details, diff]
fix warnings about type-punned pointers violating strict aliasing rules

[Comment 3 Dirk Olmes 2012-07-13 06:18:34 UTC]

Created attachment 318058 [details, diff]
fix const usage

[Comment 4 Dirk Olmes 2012-07-13 06:19:02 UTC]

Created attachment 318060 [details, diff]
fix missing field initializers

[Comment 5 Dirk Olmes 2012-07-13 06:19:27 UTC]

Created attachment 318062 [details, diff]
fix warnings about nested external declarations

[Comment 6 Dirk Olmes 2012-07-13 06:20:03 UTC]

Created attachment 318064 [details, diff]
fix prototypes for functions with no arguments

[Comment 7 Dirk Olmes 2012-07-13 06:20:35 UTC]

Created attachment 318066 [details, diff]
fix comparisons of signed and unsigned integers

[Comment 8 Dirk Olmes 2012-07-13 06:21:01 UTC]

Created attachment 318068 [details, diff]
tag possibly-unused parameters

[Comment 9 Jeroen Roovers (RETIRED) 2012-07-18 00:06:23 UTC]

Comment on attachment 318054 [details]
ebuild incorporating the additional fixes

--- pptpclient-1.7.2-r2.ebuild  2010-04-29 21:46:17.000000000 +0200
+++ -   2012-07-18 02:06:13.507044987 +0200
@@ -16,7 +16,7 @@
 
 SLOT="0"
 LICENSE="GPL-2"
-KEYWORDS="alpha amd64 ppc ppc64 x86"
+KEYWORDS="~alpha ~amd64 ~ppc ~ppc64 ~x86"
 IUSE="tk"
 
 DEPEND="net-dialup/ppp
@@ -32,6 +32,13 @@
 src_prepare() {
        epatch "${FILESDIR}"/${P}-process-name.patch
        epatch "${FILESDIR}"/${P}-ip-path.patch
+       epatch "${FILESDIR}"/${P}-sign-compare.patch
+       epatch "${FILESDIR}"/${P}-const.patch
+       epatch "${FILESDIR}"/${P}-field-init.patch
+       epatch "${FILESDIR}"/${P}-unused.patch
+       epatch "${FILESDIR}"/${P}-prototype.patch
+       epatch "${FILESDIR}"/${P}-nested-externs.patch
+       epatch "${FILESDIR}"/${P}-aliasing.patch
 }
 
 src_compile() {

[Comment 10 Nikoli 2014-08-15 20:10:12 UTC]

pptpclient-1.8.0 is now in tree, are these patches still required for latest release?

[Comment 11 Dirk Olmes 2014-08-20 23:59:23 UTC]

I downloaded the 1.8.0 release and did a cursory check of the patches and it lookls like all of them are included in the 1.8.0 release.