Summary: | media-video/mkclean-0.8.6-r1: bundles or statically links libz/libbz2 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | esigra, media-video |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://tinderboxlogs.s3.amazonaws.com/tbamd64.excelsior.flameeyes.eu/media-video%3Amkclean-0.8.6-r1%3A20120711-092253.html | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 251464 |
Description
Diego Elio Pettenò (RETIRED)
2012-07-11 09:30:18 UTC
ok, for the sed, I need a new "anchor" to place $(LDFLAGS) at the right place. for zlib, i have to look how to patch it to use the system lib. But then I guess, we will find the same "problem" in media-video/mkvalidate. and btw: it also bundles libebml/libmatroska, but i didn't found an easy solution to fix that. ok, explaination for the sed. "configure" generates *.mak files with this content: [..] LFLAGS += -static LFLAGS += $(LIBS) -L../release/gcc_linux_x64/ [..] my sed produces this: [..] LFLAGS += -static LFLAGS += $(LIBS) $(LDFLAGS) -L../release/gcc_linux_x64/ [..] but I guess, you want: [..] LFLAGS += -static LFLAGS += $(LDFLAGS) $(LIBS) -L../release/gcc_linux_x64/ [..] am I correct? Let's start with "it shouldn't have -static there at all" :) no the problem is that $(LDFLAGS) $(LIBS) or $(LIBS) $(LDFLAGS) is wrong in any case. A proper linking line is: $(CC) $(LDFLAGS) [$(CFLAGS)] $(OBJECTS) $(LIBS) the libraries have to go _after_ the object files, and possibly those should go after all the flags. Also, what is "the problem with mkvalidate"? In general, bundled libs are *bad* for Gentoo, and so are static links. I agree with you. But sometimes it's hard to fix the buildsystem. So first of all, I will fix the LDFLAGS problem. I try to find a better place to inject it. Then: mkclean/mkvalidator is not linked static, just libebml/libmatroska is. Feel free to send patches for the included libebml/libmatroska libs. btw: zlib is just part of libmatroska... Well then bother upstream. Honestly if the build system means we can't get something that at least barely fits into our policies, it's not a good reason to ignore the policy! I try what I can. But it will take some time, because it's not that easy. |