| Summary: | net-irc/bitchx 1.2 - QA/security issues | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Daniel Petre <daniel.petre> |
| Component: | Current packages | Assignee: | Packages in net-irc <net-irc> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | normal | CC: | jdhore, jer, treecleaner |
| Priority: | Normal | Keywords: | PMASKED |
| Version: | unspecified | ||
| Hardware: | x86 | ||
| OS: | Linux | ||
| Whiteboard: | Pending removal: 2015-01-01 | ||
| Package list: | Runtime testing required: | --- | |
| Attachments: | BitchX 1.2 ebuild | ||
Comment on attachment 317758 [details] BitchX 1.2 ebuild --- bitchx-1.1-r4.ebuild 2011-12-22 17:26:27.000000000 +0100 +++ - 2012-07-10 16:10:59.508362390 +0200 @@ -4,17 +4,14 @@ inherit flag-o-matic eutils -MY_PN=ircii-pana -MY_P=${MY_PN}-${PV}-final -S=${WORKDIR}/BitchX +S=${WORKDIR}/BitchX1.2 DESCRIPTION="An IRC Client" HOMEPAGE="http://www.bitchx.org/" -SRC_URI="mirror://sourceforge/${PN}/${MY_PN}/${MY_PN}-${PV}/${MY_P}.tar.gz" - +SRC_URI="http://vicodan.fedorapeople.org/BitchX1.2.tar.gz" LICENSE="GPL-2" SLOT="0" KEYWORDS="alpha amd64 arm hppa ~ia64 ppc sh sparc x86" -IUSE="cjk ipv6 ssl" +IUSE="ipv6 ssl" DEPEND=">=sys-libs/ncurses-5.1 ssl? ( >=dev-libs/openssl-0.9.6 )" @@ -22,22 +19,6 @@ src_unpack() { unpack ${A} cd "${S}" - use cjk && epatch "${FILESDIR}"/${PV}/${P}-cjk.patch - epatch "${FILESDIR}"/${PV}/${P}-pbxs.patch - epatch "${FILESDIR}"/${PV}/${P}-hebrew.patch - epatch "${FILESDIR}"/${PV}/${P}-freenode.patch - epatch "${FILESDIR}"/${PV}/${P}-gcc34.patch - epatch "${FILESDIR}"/${PV}/${P}-gcc41.patch - epatch "${FILESDIR}"/${PV}/${P}-inline.patch - epatch "${FILESDIR}"/${PV}/${P}-headers.patch - epatch "${FILESDIR}"/${PV}/${P}-build.patch - epatch "${FILESDIR}"/${PV}/${P}-open-mode.patch - epatch "${FILESDIR}"/fPIC.patch - epatch "${FILESDIR}"/BitchX-64bit.patch - - sed -i \ - -e "s/#undef LATIN1/#define LATIN1 ON/;" \ - include/config.h } src_compile() { @@ -59,16 +40,11 @@ $(use_with ssl) \ $(use_enable ipv6) \ ${myconf} || die - - emake || die "make failed" - emake -C contrib vh1 || die "make vh1 failed" + emake DESTDIR="${D}" install } src_install () { einstall || die - dobin contrib/vh1 || die - dosym BitchX-1.1-final /usr/bin/BitchX - dosym BitchX-1.1-final /usr/bin/bitchx cd "${S}" dodoc bugs Changelog README* IPv6-support @@ -86,4 +62,4 @@ newdoc arcfour/README README.arcfour newdoc blowfish/README README.blowfish newdoc qbx/README README.qbx -} +} \ No newline at end of file yep, tested it on a x86 machine - ipv6 and ssl support seem to work on freenode :) *bitchx-1.2 (02 Jan 2013) 02 Jan 2013; Jeff Horelick <jdhore@gentoo.org> +bitchx-1.2.ebuild, +files/bitchx-1.2-build.patch: Version bump Why were seven arch keywords dropped here? Why was this bug report ignored, as well as several other related bug reports, especially bug #190667? I have restored the missing keywords now. I dropped keywords because there were MANY MANY changes by upstream and i did not/do not have the hardware to test on those arches. (In reply to comment #6) > I dropped keywords because there were MANY MANY changes by upstream and i > did not/do not have the hardware to test on those arches. That's no excuse - the manual is pretty clear about notifying arch teams every time you drop keywords. I've done some more work on the ebuild, and as of now, a couple of issues stand out:
1) parallel make fails.
2) this:
In file included from /usr/include/string.h:642:0,
from network.c:33:
In function ‘bcopy’,
inlined from ‘get_address’ at network.c:52:8:
/usr/include/bits/string3.h:92:3: warning: call to __builtin___memmove_chk will always overflow destination buffer [enabled by default]
[...]
In function ‘strncpy’,
inlined from ‘asignon’ at ./cmd.c:76:10:
/usr/include/bits/string3.h:121:3: warning: call to __builtin___strncpy_chk will always overflow destination buffer [enabled by default]
In function ‘strncpy’,
inlined from ‘asignon’ at ./cmd.c:80:10:
/usr/include/bits/string3.h:121:3: warning: call to __builtin___strncpy_chk will always overflow destination buffer [enabled by default]
3) and this:
interface.c: In function ‘init_toc’:
interface.c:24:2: warning: implicit declaration of function ‘strcpy’ [-Wimplicit-function-declaration]
interface.c:24:2: warning: incompatible implicit declaration of built-in function ‘strcpy’ [enabled by default]
[...]
./md5.c: In function ‘Transform’:
./md5.c:219:4: warning: implicit declaration of function ‘memset’ [-Wimplicit-function-declaration]
./md5.c:219:4: warning: incompatible implicit declaration of built-in function ‘memset’ [enabled by default]
[...]
./europa.c: In function ‘Europa_Init’:
./europa.c:360:3: warning: implicit declaration of function ‘mysql_connect’ [-Wimplicit-function-declaration]
[...]
./llist.c: In function ‘lpush’:
./llist.c:43:7: warning: implicit declaration of function ‘memcpy’ [-Wimplicit-function-declaration]
./llist.c:43:7: warning: incompatible implicit declaration of built-in function ‘memcpy’ [enabled by default]
[...]
vh1.c: In function ‘check_inter’:
vh1.c:116:3: warning: implicit declaration of function ‘inet_ntoa’ [-Wimplicit-function-declaration]
vh1.c:119:7: warning: implicit declaration of function ‘inet_addr’ [-Wimplicit-function-declaration]
So I am inclined to package.mask this version along with the older one, and then get these problems fixed, along with a few others ("warning: the address of `$some_variable' will always evaluate as `true'", for instance).
@Jer, are you still planning to work on this? Otherwise, I'd like to mark it for treecleaning. (In reply to Michał Górny from comment #9) > @Jer, are you still planning to work on this? Otherwise, I'd like to mark it > for treecleaning. removed |
Created attachment 317758 [details] BitchX 1.2 ebuild hello, tested the attached ebuild, compiles fine with ssl and ipv6 support. it would be cool if you guys can add it to official portage instead of the old masked version. thanks!