Summary: | =media-libs/lensfun-0.2.6 with Prefix support | ||
---|---|---|---|
Product: | Gentoo/Alt | Reporter: | Nicolas Pinto <nicolas.pinto> |
Component: | Prefix Support | Assignee: | Gentoo Graphics Project <graphics+disabled> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | prefix |
Priority: | Normal | Keywords: | InVCS, PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 434086 | ||
Bug Blocks: | 315803 | ||
Attachments: |
patch
patch for lensfun-0.2.6.ebuild |
Description
Nicolas Pinto
2012-07-08 15:56:13 UTC
Please attach a patch. Also, include what keyword you tested. Thanks. Created attachment 317742 [details, diff]
patch
Tested on ~amd64-linux. 0.2.5_p153 is obsolete and shouldn't be used anymore in favour of 0.2.6 (In reply to comment #4) > 0.2.5_p153 is obsolete and shouldn't be used anymore in favour of 0.2.6 The concept is the same, approve? Comment on attachment 317742 [details, diff]
patch
- Missing "" quoting for ${EPREFIX}
- Using {} instead of () for get_libdir function, doesn't work
- After changing the {} to () it compiles but installs everything into / instead of /usr
So definate no-go for this patch, it wasn't even tested
(In reply to comment #6) > Comment on attachment 317742 [details, diff] [details, diff] > patch > > - Missing "" quoting for ${EPREFIX} > - Using {} instead of () for get_libdir function, doesn't work > - After changing the {} to () it compiles but installs everything into / > instead of /usr > > So definate no-go for this patch, it wasn't even tested The need to set CMAKE_INSTALL_LIBDIR is actually bug #434086, I will updated the patch as soon as this one is fixed. Created attachment 324468 [details, diff]
patch for lensfun-0.2.6.ebuild
Only one trivial change left.
(In reply to comment #8) > Created attachment 324468 [details, diff] [details, diff] > patch for lensfun-0.2.6.ebuild > > Only one trivial change left. please apply it in tree (no revbump required) Done, thanks. |