Summary: | x11-libs/gksu: removal (was: replace with pkexec in application launchers) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Pacho Ramos <pacho> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | mgorny, slawomir.nizio, ssuominen, treecleaner |
Priority: | Normal | Keywords: | PMASKED |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=534540 | ||
Whiteboard: | Pending removal: 2018-12-11 | ||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 486440, 486442, 486444, 486446, 486448, 486452, 486456, 486458, 486460, 486462, 594214, 670268 | ||
Bug Blocks: | 534540 |
Description
Pacho Ramos
2012-07-07 11:59:52 UTC
I have been wondering about this as well. What about gksu-polkit ? https://live.gnome.org/gksu/ This seems to be what is being used by debian currently. Not sure what would be "the best" :/ Any thoughts from other team members? My vote is for gksu-polkit because it comes with a library (libgksu-polkit) that we can hopefully use to replace x11-libs/libgksu. I have added app-admin/gksu-polkit-0.0.3 to portage. Seems to work well. But, isn't more secure the way pkexec (that is the solution offered directly by polkit) works than "old gksu way"? I am referring to "Security notes" chapter you can read in "man pkexec" We should probably ask upstream about this, but given that polkit implemented X support for this very purpose, this is most likely what we should use. Also, libgksu isn't used by many packages: http://qa-reports.gentoo.org/output/genrdeps/rindex/x11-libs/libgksu vmware should probably start using policykit directly :) I made this optional in gparted behind policykit use flag. Let's see how it works :) >=xfce-extra/xfce4-taskmanager-1.0.1 started using libgksu to provide 'Run as root' option in it's menu which seems handy. It's now USE="gksu" in Portage. I don't think this bug applies to it, since it's using the library instead of the command :-/ http://qa-reports.gentoo.org/output/genrdeps/rindex/x11-libs/libgksu With that said, I'll try to poke upstream to switch. $ rdep */libgksu ==rdep== app-emulation/vmware-player-7.1.2.2780323-r1 app-emulation/vmware-workstation-10.0.6.2700073-r1 app-emulation/vmware-workstation-11.1.2.2780323-r4 app-emulation/vmware-workstation-11.1.3.3206955-r3 app-emulation/vmware-workstation-11.1.3.3206955-r4 app-emulation/vmware-workstation-9.0.3.1410761 x11-libs/gksu-2.0.2-r1 xfce-extra/xfce4-taskmanager-1.0.1:gksu xfce-extra/xfce4-taskmanager-1.1.0:!gtk3+gksu xfce-extra/xfce4-taskmanager-1.2.0:!gtk3+gksu $ rdep */gksu ==rdep== mate-extra/caja-extensions-1.12.0-r2:gksu mate-extra/caja-extensions-1.14.1-r1:gksu mate-extra/caja-extensions-1.16.0-r1:gksu mate-extra/caja-extensions-1.18.1:gksu Yeah, initially there were more libgksu reverse deps and, hence, I have priority to kill gksu sooner... but looking now that there are only a few revdeps in the tree for that... I have filled the relevant bug reports to see if we can kill it too The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7f480aa65b18043d59ebd3742ea8927a90f786d5 commit 7f480aa65b18043d59ebd3742ea8927a90f786d5 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2018-12-11 14:00:51 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2018-12-11 14:00:51 +0000 x11-libs/libgksu: Remove last-rited pkg Closes: https://bugs.gentoo.org/425156 Signed-off-by: Michał Górny <mgorny@gentoo.org> profiles/package.mask | 5 - x11-libs/libgksu/Manifest | 1 - x11-libs/libgksu/files/libgksu-2.0.0-fbsd.patch | 60 ---- .../files/libgksu-2.0.12-automake-1.11.2-v2.patch | 61 ---- .../files/libgksu-2.0.12-automake-1.11.2.patch | 25 -- .../libgksu-2.0.12-correct_colormap_get.patch | 12 - .../files/libgksu-2.0.12-desktop-validation.patch | 16 - .../files/libgksu-2.0.12-fix-make-3.82.patch | 21 -- .../files/libgksu-2.0.12-format_security.patch | 28 -- ...u-2.0.12-g_markup_escape_text_for_command.patch | 21 -- .../files/libgksu-2.0.12-missing-libs.patch | 22 -- .../libgksu/files/libgksu-2.0.12-notests.patch | 26 -- .../files/libgksu-2.0.12-revert-forkpty.patch | 359 --------------------- .../files/libgksu-2.0.12-sudo_keep_env.patch | 15 - x11-libs/libgksu/files/libgksu-2.0.7-libs.patch | 76 ----- .../libgksu/files/libgksu-2.0.7-polinguas.patch | 40 --- x11-libs/libgksu/libgksu-2.0.12-r3.ebuild | 81 ----- x11-libs/libgksu/libgksu-2.0.12-r4.ebuild | 82 ----- x11-libs/libgksu/metadata.xml | 8 - 19 files changed, 959 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=43fc584e95a71b1115a8e73629d87c2f233d3fbc commit 43fc584e95a71b1115a8e73629d87c2f233d3fbc Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2018-12-11 13:58:31 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2018-12-11 14:00:27 +0000 x11-libs/gksu: Remove last-rited pkg Closes: https://bugs.gentoo.org/425156 Signed-off-by: Michał Górny <mgorny@gentoo.org> profiles/arch/alpha/package.use.stable.mask | 3 +- profiles/arch/arm/package.use.stable.mask | 3 +- profiles/arch/arm64/package.use.mask | 1 - profiles/arch/ia64/package.use.stable.mask | 3 +- .../arch/powerpc/ppc32/package.use.stable.mask | 3 +- .../arch/powerpc/ppc64/package.use.stable.mask | 3 +- profiles/arch/sparc/package.use.stable.mask | 3 +- profiles/package.mask | 1 - x11-libs/gksu/Manifest | 1 - .../gksu/files/gksu-2.0.2-format_security.patch | 37 ---------- x11-libs/gksu/files/gksu-2.0.2-glib-2.31.patch | 29 -------- x11-libs/gksu/files/gksu-2.0.2-nautilus-dir.patch | 58 --------------- x11-libs/gksu/gksu-2.0.2-r2.ebuild | 85 ---------------------- x11-libs/gksu/metadata.xml | 8 -- 14 files changed, 6 insertions(+), 232 deletions(-) |