Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 425100

Summary: repoman: missing SRC_URI should be fatal
Product: Portage Development Reporter: Rick Farina (Zero_Chaos) <zerochaos>
Component: RepomanAssignee: Portage team <dev-portage>
Status: RESOLVED DUPLICATE    
Severity: normal    
Priority: Normal    
Version: 2.1   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Rick Farina (Zero_Chaos) gentoo-dev 2012-07-06 21:18:54 UTC
if [[ ${PV} == "9999" ]] ; then
        EGIT_REPO_URI="http://git.code.sf.net/p/libbtbb/code"
        inherit git-2
        KEYWORDS=""
else
        SRC_URI="mirror://sourceforge/${PN}/${P}.tar.gz"
        KEYWORDS="~amd64 ~arm ~x86"
fi


I have something like this is nearly all my ebuilds and repoman had no problem with it.

It should have failed when scanning (in this case) libbtbb-9999 as it would not have defined SRC_URI
Comment 1 Jeff (JD) Horelick (RETIRED) gentoo-dev 2012-07-06 21:30:55 UTC
I personally think it is fine for missing SRC_URI to not be a fatal error.

There are plenty of cases where the source files are in FILESDIR or it's a -9999 package, both of which have no need for a SRC_URI
Comment 2 Rick Farina (Zero_Chaos) gentoo-dev 2012-07-06 22:01:05 UTC
(In reply to comment #1)
> I personally think it is fine for missing SRC_URI to not be a fatal error.
> 
> There are plenty of cases where the source files are in FILESDIR or it's a
> -9999 package, both of which have no need for a SRC_URI

The dev manual defines SRC_URI as a required variable...

http://devmanual.gentoo.org/ebuild-writing/variables/index.html

Either it's optional or it isn't but something needs to change as the devmanual defines it as required but emerge and repoman don't care at all (not even a warning) if it is missing.
Comment 3 SpanKY gentoo-dev 2012-07-18 22:12:13 UTC

*** This bug has been marked as a duplicate of bug 425848 ***