Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 423327

Summary: games-rpg/eternal-lands bundles minizip
Product: Gentoo Linux Reporter: Richard Freeman <rich0>
Component: [OLD] GamesAssignee: Richard Freeman <rich0>
Status: RESOLVED FIXED    
Severity: normal CC: games, ssuominen
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: eternal-lands-1.9.3-r2.ebuild.diff
eternal-lands-1.9.3-minizip.patch
eternal-lands-1.9.3-r2.ebuild.diff
eternal-lands-1.9.3-r2.ebuild.diff

Description Richard Freeman gentoo-dev 2012-06-24 15:12:33 UTC
Patch to use system zlib[minizip].
Comment 1 Julian Ospald 2012-06-24 17:00:09 UTC
Created attachment 316167 [details, diff]
eternal-lands-1.9.3-r2.ebuild.diff

ebuild diff
Comment 2 Julian Ospald 2012-06-24 17:00:12 UTC
Created attachment 316169 [details, diff]
eternal-lands-1.9.3-minizip.patch

I guess we would need to test the update thingy since it seems to make use of minizip shit.
Comment 3 Julian Ospald 2012-06-24 17:01:20 UTC
oh, and the package is obviously missing virtual/pkgconfig...
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2012-06-24 17:14:49 UTC
The patch looks good to me
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2012-06-24 17:48:42 UTC
The ebuild patch should also remove the `sed` line that adds the OF change when this gets committed
Comment 6 Julian Ospald 2012-06-24 17:52:44 UTC
Created attachment 316173 [details, diff]
eternal-lands-1.9.3-r2.ebuild.diff

right, fixed that, added pkgconfig, fixed the usex line
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2012-06-24 17:58:38 UTC
and the actual sys-libs/zlib[minizip] dep? :)
Comment 8 Julian Ospald 2012-06-24 18:05:39 UTC
Created attachment 316175 [details, diff]
eternal-lands-1.9.3-r2.ebuild.diff

(In reply to comment #7)
> and the actual sys-libs/zlib[minizip] dep? :)

done that, reordered deps alphabetically and slotted libpng.
Comment 9 Richard Freeman gentoo-dev 2012-12-02 23:21:24 UTC
Thanks for the patches - fixed today with the build error.