Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 422897

Summary: app-portage/gentoolkit-9999 has several failing doctests
Product: Portage Development Reporter: W. Trevor King <wking>
Component: ToolsAssignee: Portage Tools Team <tools-portage>
Status: RESOLVED FIXED    
Severity: minor    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Nosetest log from running gentoolkit doctests.

Description W. Trevor King 2012-06-21 20:19:34 UTC
Created attachment 315935 [details]
Nosetest log from running gentoolkit doctests.

Steps to reproduce:

    $ git clone git://git.overlays.gentoo.org/proj/gentoolkit.git
    $ cd gentoolkit
    $ git checkout -b dev origin/gentoolkit
    $ nosetests --with-doctest --doctest-tests pym/
    …
    Ran 43 tests in 57.266s

    FAILED (errors=5, failures=12)

I've attached the full test log in case you're curious.  I haven't gone through all the failures yet, I imagine some of them should just be skipped.  However, the NameErrors are definately due to crufty documentation.  Should I submit patches that fix those in this bug, or open a new bug for each fix?
Comment 1 W. Trevor King 2012-06-21 20:24:09 UTC
Oh, just to be clear about exactly which revision I'm talking about:

    $ git rev-parse HEAD
    6b94fbd3b74471cf9740a35d669963e0b6c84eac
    $ git describe --tags
    gentoolkit-0.3.0.6-11-g6b94fbd
Comment 2 Paul Varner (RETIRED) gentoo-dev 2012-11-06 17:47:24 UTC
If you have patches that apply against the current HEAD go ahead and attach them and I will commit them to the repository.
Comment 3 W. Trevor King 2012-11-12 03:30:38 UTC
30+ commits is too many for me to bother attaching individually, so I've just pushed my Git tree to:

  git://tremily.us/gentoolkit.git

Rather than basing so many doctests on the user's installed package tree, it seems like it would be better to run the tests on a dummy tree.  I'm not sure how to go about setting that up though.
Comment 4 Paul Varner (RETIRED) gentoo-dev 2012-11-13 20:49:34 UTC
Thanks, all commits from your branch have been pushed.  If you have anything else, you can comment here (even though the bug is closed) or you can email me at fuzzyray at gentoo.org