Bug 421141

Summary:	app-emulation/open-vm-tools-kmod fails to build on FreeBSD
Product:	Gentoo/Alt	Reporter:	Richard Yao (RETIRED) <ryao>
Component:	FreeBSD	Assignee:	Mike Gilbert <floppym>
Status:	RESOLVED OBSOLETE
Severity:	enhancement	CC:	bsd+disabled, vmware+disabled
Priority:	Normal	Keywords:	Inclusion, InOverlay
Version:	unspecified
Hardware:	All
OS:	FreeBSD
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	421291

Description Richard Yao (RETIRED) gentoo-dev

2012-06-14 17:52:12 UTC

uaie informed me in #gentoo-bsd on freenode that Gentoo FreeBSD does not have proper drivers for VMWare ESXi.

I committed a modified 	app-emulation/open-vm-tools-kmod-2012.05.21.724730 ebuild to an overlay that adds FreeBSD support.

https://github.com/ryao/gentoofan-overlay/tree/master/app-emulation/open-vm-tools-kmod

Note that I wrote the following patches:

open-vm-tools-kmod-2012.05.21.724730-fbsd-hgfscloseint-return.patch
open-vm-tools-kmod-2012.05.21.724730-fbsd-vmhgfs-makefile.patch
open-vm-tools-kmod-2012.05.21.724730-fbsd-vmhgfs-debug.patch

The the remaining patches are from FreeBSD ports. I changed the names to match Gentoo naming conventions, although I am not sure if that is the right thing to do. Maybe it might be better to place them in "${FILESDIR}/contrib" with the file names unchanged.

Please let me know what needs to be done for this work to enter the main tree.

Comment 1 Richard Yao (RETIRED) gentoo-dev

2012-06-14 18:01:13 UTC

I erroneously listed open-vm-tools-kmod-2012.05.21.724730-fbsd-vmhgfs-makefile.patch as one of the patches I wrote. That one is from FreeBSD. It replaced a patch that I began to write for the same failures.

Comment 2 Andreas K. Hüttel archtester

2013-06-22 22:33:03 UTC

Hi Richard, 

the ebuilds here are out of date, but if you are willing to update your stuff and eventually maintain it, feel free to commit it to the main tree. 

Three request:

1) please encapsulate everything you do into 
if use freebsd... 
  # applying patches 
  ...
fi
 - _also_ the freebsd-specific patches. (I know that normally conditional patching is discouraged, but imho here it makes sense.)

2) please add yourself in metadata then too

3) please commit identical ebuilds to the vmware overlay (all devs may push there, and right now it "mirrors" the vmware packages from the main tree, we may change that policy soon though).

Comment 3 Andreas K. Hüttel archtester

2014-04-12 18:08:34 UTC

(In reply to Andreas K. Hüttel from comment #2)
> Hi Richard, 
> 
> the ebuilds here are out of date, but if you are willing to update your
> stuff and eventually maintain it, feel free to commit it to the main tree. 
> 
> Three request:
> 
> 1) please encapsulate everything you do into 
> if use freebsd... 
>   # applying patches 
>   ...
> fi
>  - _also_ the freebsd-specific patches. (I know that normally conditional
> patching is discouraged, but imho here it makes sense.)
> 
> 2) please add yourself in metadata then too
> 
> 3) please commit identical ebuilds to the vmware overlay (all devs may push
> there, and right now it "mirrors" the vmware packages from the main tree, we
> may change that policy soon though).

Ping. 

The vmware overlay is dead, in-tree maintenance only.

Comment 4 Andreas K. Hüttel archtester

2015-09-27 21:45:30 UTC

Please reopen if still interested.