| Summary: | media-sound/kwave-0.8.8 ebuild needs fixing | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Thomas <Thomas.Eschenbacher> |
| Component: | [OLD] KDE | Assignee: | Gentoo KDE team <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
(In reply to comment #0) > 3) MMX support was dropped, this line (+ the use flag) are missing: > use mmx && append-flags -mmmx Is there a reason to do this, rather than rely on user CFLAGS? I've committed a revision bump fixing most of the issues you raised. Please re-open if you have more information regarding the mmx issue. +*kwave-0.8.8-r1 (25 Jun 2012) + + 25 Jun 2012; Michael Palimaka <kensington@gentoo.org> +kwave-0.8.8-r1.ebuild, + -kwave-0.8.8.ebuild, metadata.xml: + Make libsamplerate mandatory and phonon optional. Require + imagemagick/graphicsmagick to be built with SVG. Add document containing + detailed licensing information. Update metadata. Thanks to Thomas + <Thomas.Eschenbacher@gmx.de> in bug #420719. |
I recently saw that an ebuild for kwave-0.8.8 came into portage. Unfortunately some things got lost/broken compared with the original version, so please synchronize it with the latest upstream version I published with v0.8.8: 1) libsamplerate is no longer a reasonable config option, the program is not fully functional without libsamplerate => should not be configured at all (internal default is "ON") => please remove use flag and cmake option + make dependency unconditional 2) the "LICENSES" file is not included in the DOCS list (no, this is not the GPL or any other license text!) 3) MMX support was dropped, this line (+ the use flag) are missing: use mmx && append-flags -mmmx Another thing is missing svg support: I received a bug report today telling that Kwave does not build if imagemagick is built without the svg use flag, so please change the corresponding line like this: || ( media-gfx/imagemagick[png,svg] media-gfx/graphicsmagick[imagemagick,png,svg] )