Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 418243

Summary: media-plugins/frei0r-plugins-1.3: fails to build on multilib-portage due to invalid CMake configuration
Product: Gentoo Linux Reporter: thomasg <thomas>
Component: [OLD] UnspecifiedAssignee: Gentoo Media-video project <media-video>
Status: RESOLVED FIXED    
Severity: normal CC: crabbedhaloablution, flameeyes
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: frei0r-plugins-1.3_fix-filters-cflags.patch
frei0r-plugins-1.3-cflags-ebuild.patch

Description thomasg 2012-05-30 13:25:52 UTC
Created attachment 313609 [details, diff]
frei0r-plugins-1.3_fix-filters-cflags.patch

A small number of frei0r-plugins filters is built using -std=c99, but due to a wrong CMake configuration this overwrites all local and system CFLAGS.

Attached is a patch which fixes the issue, as well as a patch for the ebuild - for convenience.
This is especially important for multilib builds which fail due to the lack of passed -m32, but it also affects normal users of course (if only in performance).

I also sent the patch upstream and I assume it will get in sooner or later, but I'm also fairly certain that there will be no bugfix-release for the 1.3, so providing the fix in portage for now makes sense.
Comment 1 thomasg 2012-05-30 13:28:37 UTC
Created attachment 313611 [details, diff]
frei0r-plugins-1.3-cflags-ebuild.patch

Patch for the ebuild to include the fix.
Comment 2 crabbed halo ablution 2012-08-03 19:46:46 UTC
Ping? Simple patch which makes the package actually respect CFLAGS, patch for ebuild also included. Any takers?
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2012-08-04 07:33:43 UTC
(In reply to comment #2)
> Ping? Simple patch which makes the package actually respect CFLAGS, patch
> for ebuild also included. Any takers?

sounds like you want your commit access back ;)
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2012-08-04 08:01:45 UTC
Fixed in Portage (used sed in the ebuild)
Comment 5 Johannes Huber (RETIRED) gentoo-dev 2017-01-30 14:34:12 UTC
*** Bug 427958 has been marked as a duplicate of this bug. ***