Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 418079

Summary: sci-mathematics/form -- Symbolic Manipulation System
Product: Gentoo Linux Reporter: Jauhien Piatlicki (RETIRED) <jauhien>
Component: New packagesAssignee: Default Assignee for New Packages <maintainer-wanted>
Status: RESOLVED FIXED    
Severity: normal CC: sci-mathematics
Priority: Normal Keywords: EBUILD
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://www.nikhef.nl/~form/
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: form-4.0_p20120529.ebuild
form-4.0_p20120529.ebuild

Description Jauhien Piatlicki (RETIRED) gentoo-dev 2012-05-29 03:07:50 UTC
Created attachment 313465 [details]
form-4.0_p20120529.ebuild

FORM is symbolic manipulation system primarily developed for doing calculations in Physics.
Comment 1 Jauhien Piatlicki (RETIRED) gentoo-dev 2012-05-31 10:43:22 UTC
Created attachment 313695 [details]
form-4.0_p20120529.ebuild

ebuild after review
Comment 2 Mark Wright gentoo-dev 2012-05-31 11:41:23 UTC
Thanks, did you want to proxy maintain this package?
http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml
Comment 3 Jauhien Piatlicki (RETIRED) gentoo-dev 2012-05-31 12:02:30 UTC
(In reply to comment #2)
> Thanks, did you want to proxy maintain this package?
> http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml

Yes, I would like to do it. Will you be a Commiter?
Comment 4 Andrey Grozin gentoo-dev 2012-05-31 12:04:29 UTC
At the moment I'm working with this ebuild. Some changes are necessary. I'll commit it in 15 minutes or so.
Comment 5 Jauhien Piatlicki (RETIRED) gentoo-dev 2012-05-31 12:05:33 UTC
Ok, thanks
Comment 6 Andrey Grozin gentoo-dev 2012-05-31 12:10:33 UTC
The last change is wrong. If use doc (or doxygen or devref) is false, the ebuild calls die immediately. See

grozin@eeepc ~ $ true && echo "build" && echo "install" || echo "die"
build
install
grozin@eeepc ~ $ false && echo "build" && echo "install" || echo "die"
die

Also, the documentation building must be in src_compile, not in src_install. I've changed the name of the use flag threaded to threads, it is a global use flag, see use.desc. And I removed the scalar use flag - I think it's better to always build scalar form.
Comment 7 Andrey Grozin gentoo-dev 2012-05-31 12:26:36 UTC
Many thanks, committed.

dodoc dzips files, it's better to use doins for *.pdf
Comment 8 Jauhien Piatlicki (RETIRED) gentoo-dev 2012-05-31 12:33:46 UTC
Thank once again!
Comment 9 Jauhien Piatlicki (RETIRED) gentoo-dev 2012-05-31 20:19:06 UTC
I've looked through the ebuild in cvs. You have not changed SRCURI. The sources really are cvs snapshot and as far as I understand they should be placed on gentoo mirror.
This ebuild primarily was aimed for the sunrise overlay, so it was normally to keep sources on my little github mirror, but as far as you've added it to the main tree you should, perhaps, upload sources to the gentoo mirror.
Comment 10 Jauhien Piatlicki (RETIRED) gentoo-dev 2012-05-31 20:23:19 UTC
And another question shouldn't be there || die after pushd?
Comment 11 Thomas Kahle (RETIRED) gentoo-dev 2012-06-01 21:24:16 UTC
Tested and added ~amd64 keyword.
Comment 12 Andrey Grozin gentoo-dev 2012-06-02 06:24:28 UTC
Thanks
Comment 13 Jauhien Piatlicki (RETIRED) gentoo-dev 2012-06-02 09:59:39 UTC
Many thanks for your work