Summary: | repoman should warn about "emake DESTDIR="${ED}" usage | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Pacho Ramos <pacho> |
Component: | Repoman | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED OBSOLETE | ||
Severity: | enhancement | CC: | prefix |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Pacho Ramos
2012-05-26 08:21:43 UTC
(In reply to comment #0) > the problem is that I have seen a lot of ebuilds wrongly using "ED" instead > of "D" for this, maybe a repoman check could help to fix this This is correct. I'm affraid this can at max be a warning though, as many devs that introduce ED for make install find that that "makes things work", even though that's rarely the correct way of doing it. Would have helped to prevent recent breakage of rsync though. On a second thought, making it fatal would make sense, just write ${D}${EPREFIX} to make clear it's on purpose This is no longer really necessary. |