Summary: | dev-libs/libffi-3.0.11 fails to build with Clang on Gentoo FreeBSD | ||
---|---|---|---|
Product: | Gentoo/Alt | Reporter: | Richard Yao (RETIRED) <ryao> |
Component: | FreeBSD | Assignee: | Gentoo Toolchain Maintainers <toolchain> |
Status: | RESOLVED FIXED | ||
Severity: | QA | Keywords: | Bug, PATCH |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | FreeBSD | ||
URL: | https://bugzilla.mozilla.org/show_bug.cgi?id=631928 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 417789 | ||
Attachments: |
dev-libs/libffi-3.0.11 build failure
Patch to fix dev-libs/libffi-3.0.11 build failure on FreeBSD Mozilla patch to fix build failure Upstream patch to fix issue |
Description
Richard Yao (RETIRED)
2012-05-22 23:47:10 UTC
Created attachment 312767 [details, diff]
Patch to fix dev-libs/libffi-3.0.11 build failure on FreeBSD
FreeBSD's devel/libffi port applies a configure script patch that removes ${CFLAGS} from a test, among a few other fixes (ppc64-freebsd support). The patch doesn't apply cleanly against libffi, so I wrote a new patch that does.
This fixes the build failure on Gentoo FreeBSD.
Comment on attachment 312767 [details, diff]
Patch to fix dev-libs/libffi-3.0.11 build failure on FreeBSD
seems to me this will break when CFLAGS contains flags that change the ABI
My time to work on this is limited for the next 2 weeks. If I do not have a new patch in 3 weeks, please ping me. Created attachment 313299 [details, diff]
Mozilla patch to fix build failure
The Mozilla developers wrote a patch for this that was sent upstream.
Comment on attachment 313299 [details, diff]
Mozilla patch to fix build failure
can't say this patch makes me all warm&fuzzy ... but certainly if upstream accepts it, feel free to merge into our ebuild ...
The Mozilla developers do not appear to have sent this patch upstream. I have opened an issue report on the upstream github bug tracker: https://github.com/atgreen/libffi/issues/21 (In reply to comment #6) > The Mozilla developers do not appear to have sent this patch upstream. I > have opened an issue report on the upstream github bug tracker: > > https://github.com/atgreen/libffi/issues/21 Upstream is non-responsive. Could we commit without waiting for upstream? I have added epatch_user support to the dev-libs/libffi so that users will not need to wait for us to apply this to this tree. (In reply to comment #7) clean up the patch and attach a new version http://dev.gentoo.org/~vapier/clean-patches (In reply to comment #6) > The Mozilla developers do not appear to have sent this patch upstream. I > have opened an issue report on the upstream github bug tracker: > > https://github.com/atgreen/libffi/issues/21 wrong place, the patches for libffi get submitted to the libffi-discuss mailing list for review Created attachment 335246 [details, diff]
Upstream patch to fix issue
Upstream has written a patch for this issue. I can confirm that it works. May I commit?
By the way, the original patch is here: https://github.com/atgreen/libffi/commit/bff052d9cd5be41ba9e47c76114054af487d3c30 I deleted the Changelog hunk from what I attached because it prevents the patch from applying properly. should be all set now in the tree; thanks for the report! Commit message: Add fix from upstream for PIC compile checks http://sources.gentoo.org/dev-libs/libffi/files/libffi-3.0.11-x86-pic-check.patch?rev=1.1 http://sources.gentoo.org/dev-libs/libffi/libffi-3.0.11.ebuild?r1=1.17&r2=1.18 |