Bug 416565 – dev-python/pycairo should support xpyb

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Martin Scholz 2012-05-18 21:56:05 UTC]

For some apps it would be nice if pycairo would support xpyb, so far it is not possible to get qtile cause of that missing feature working without compiling py2cairo on your own, so for a pure portage solution it would be nice to get pycairo build with xpyb support, then a pure support of qtile in gentoo/funtoo would be possible and another great WM would make it's way into the portage tree... :)

[Comment 1 Mike Gilbert 2012-05-21 03:40:12 UTC]

Per IRC discussion, xpyb support seems to be present in the autotools build system, but not waf.

As well, it seems like the xpyb support in the autotools code would introduce an automagic dependency.

[Comment 2 Jonathan Sielhorst 2012-11-12 07:07:46 UTC]

Created attachment 329302 [details, diff]
patch for py2cairo xpyb support with waf build

[Comment 3 Jonathan Sielhorst 2012-11-12 07:10:59 UTC]

Created attachment 329304 [details, diff]
patch for pycairo xpyb support with waf build

This and patch 329302 is the proposed solution of https://bugs.freedesktop.org/show_bug.cgi?id=50134.

Works for me on my amd64 machine.

[Comment 4 Jonathan Sielhorst 2012-11-12 07:51:17 UTC]

Created attachment 329310 [details, diff]
added diff comment and fixed reformat as suggested in #gentoo-python

[Comment 5 Jonathan Sielhorst 2012-11-12 07:51:59 UTC]

Created attachment 329312 [details]
added diff comment and fixed reformat as suggested in #gentoo-python

[Comment 6 Tim Harder 2012-11-12 12:09:31 UTC]

These patches just seem to add an automagic dep on xpyb without even setting the proper compile flag (-DHAVE_XPYB) that is required to build the xpyb codepaths.

[Comment 7 Jonathan Sielhorst 2012-11-12 20:05:21 UTC]

I just took what they introduced in their master.
http://cgit.freedesktop.org/py2cairo/commit/?id=2f1f3788fa2d9b693c77645edc44f35e7073aadd

And made my own test ebuild:
https://github.com/baudvix/bvix-overlay/blob/master/dev-python/pycairo/pycairo-1.10.0-r3.ebuild

I'm not sure how waf exactly works, but qtile works with the patch.

[Comment 8 Jonathan Sielhorst 2012-11-13 03:43:56 UTC]

Created attachment 329430 [details, diff]
fixes automagic dep

Ok i read about automagic dep.
Introduced the xcb useflag and just add the patch if its enabled.

I just started reading the dev manuals.
Thanks for your patient

[Comment 9 Tim Harder 2012-11-13 04:33:44 UTC]

(In reply to comment #8)
> Created attachment 329430 [details, diff] [details, diff]
> fixes automagic dep
> 
> Ok i read about automagic dep.
> Introduced the xcb useflag and just add the patch if its enabled.

Conditional patching is generally to be avoided.

[Comment 10 Tim Harder 2012-11-13 04:41:37 UTC]

Fixed in pycairo-1.10.0-r3.