Bug 416477 – net-misc/l7-filter-userspace - In member function ‘u_int32_t l7_queue::handle_packet(nfq_data*, nfq_q_handle*)’: l7-queue.cpp:199:51: error: invalid conversion from ‘unsigned char**’ to ‘char**’

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description bjozac 2012-05-18 09:16:40 UTC]

There seems to be some e-build errors for the l7-filter-userspace package.

Probably dependencies which are not handled

First problem i ran into was missing 'net-libs/libnfnetlink'.
When I manually emerged it I got the next problem;


make[1]: Entering directory `/var/tmp/portage/net-misc/l7-filter-userspace-0.12_beta1/work/l7-filter-userspace-0.12-beta1'
i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I.     -O2 -pipe -march=native -fomit-frame-pointer -c -o l7-classify.o l7-classify.cpp
l7-classify.cpp: In function ‘char** readl7dir(std::string)’:
l7-classify.cpp:161:16: warning: deprecated conversion from string constant to ‘char*’
i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I.     -O2 -pipe -march=native -fomit-frame-pointer -c -o l7-queue.o l7-queue.cpp
l7-queue.cpp: In member function ‘u_int32_t l7_queue::handle_packet(nfq_data*, nfq_q_handle*)’:
l7-queue.cpp:199:51: error: invalid conversion from ‘unsigned char**’ to ‘char**’
l7-queue.cpp:199:51: error:   initializing argument 2 of ‘int nfq_get_payload(nfq_data*, char**)’
make[1]: *** [l7-queue.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/net-misc/l7-filter-userspace-0.12_beta1/work/l7-filter-userspace-0.12-beta1'
make: *** [all] Error 2


I hope all needed info is in the attached zip file

[Comment 1 bjozac 2012-05-18 09:17:00 UTC]

Created attachment 312177 [details]
log files

[Comment 2 Andrew Savchenko 2012-05-18 15:25:40 UTC]

Hello,

your first problem is a missed dependency bug. This will be fixed in the tree soon.

Compilation issue is strange: looks like your net-libs/libnetfilter_queue version is too old, in 1.0.1 /usr/include/libnetfilter_queue/libnetfilter_queue.h contains:
extern int nfq_get_payload(struct nfq_data *nfad, unsigned char **data);

What version of libnetfilter_queue are you using? Looks like version requirement should be added.

[Comment 3 Andrew Savchenko 2012-05-18 15:29:38 UTC]

I checked libnetfilter_queue sources, you must use at least version 1.0.0, will post a patch later.

[Comment 4 Andrew Savchenko 2012-05-18 15:42:23 UTC]

Created attachment 312197 [details, diff]
l7-filter-userspace-0.12_beta1.ebuild.patch

Please try the following patch.

[Comment 5 Kacper Kowalik (Xarthisius) (RETIRED) 2012-05-18 15:56:01 UTC]

+  18 May 2012; Kacper Kowalik <[e-mail]>
+  l7-filter-userspace-0.12_beta1.ebuild:
+  (proxy commit) update dependencies wrt #416477 by <[e-mail]>
+

[Comment 6 bjozac 2012-05-19 07:52:05 UTC]

1) net-libs/libnetfilter_queue needed the ~arch flag to get 1.0

2) My ebuild looks like the one suggested already



Issue solved by the following in package.keywords and some manual package emerging


net-misc/l7-protocols ~x86
net-misc/l7-filter-userspace ~x86
net-libs/libnetfilter_queue ~x86

[Comment 7 Andrew Savchenko 2012-05-19 09:39:48 UTC]

Hello,

net-misc/l7-filter-userspace is not keyworded as stable, that's why we are not obligated to depend on stable versions of other packages.

Anyway, the problem was in omitted dependency and version requirement. And now it is solved.