Summary: | app-arch/dump-0.4.44-r1 restore crashes restoring UNIX-domain socket with very long name | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Christopher Head <bugs> |
Component: | [OLD] Core system | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | PATCH |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
URL: | https://sourceforge.net/p/dump/code/ci/da3c0e859f79616dc312dd85a86dee06628d7dcb/ | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Patch to fix the crash |
Description
Christopher Head
2012-05-17 09:07:48 UTC
Created attachment 312095 [details, diff]
Patch to fix the crash
As a matter of fact, I can empirically confirm that changing all the socket-restoring stuff to a single mknod() call does, in fact, fix the crash, and in the process also fixes a file descriptor leak in an error path (specifically the bind() failure case). I've attached a patch.
i've pushed your fix upstream: https://sourceforge.net/p/dump/code/ci/da3c0e859f79616dc312dd85a86dee06628d7dcb/ in the future, please post your patches upstream rather than here. |