| Summary: | contributed ebuild for latex2rtf (a latex to rtf translator) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Pablo De Nápoli <pdenapo> |
| Component: | New packages | Assignee: | Text-Markup Team (OBSOLETE) <text-markup+disabled> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | Keywords: | EBUILD |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://latex2rtf.sourceforge.net/ | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
my ebuild for latex2rtf
my Makefile for latex2rtf modified ebuild a modified version of the Makefile |
||
|
Description
Pablo De Nápoli
2004-02-14 10:58:02 UTC
Created attachment 25609 [details]
my ebuild for latex2rtf
Created attachment 25610 [details]
my Makefile for latex2rtf
put it in /usr/portage/latex2rtf-1.9.14/files/Makefile
Hi, thanks for submitting the ebuild. However, there are several
things I should mention before taking it to Portage tree.
1) app-text/tetex should be virtual/tetex, otherwise app-text/ptex
and app-text/cstetex users won't take benefit of the package ;)
2) Write ${P}.tar.gz instead of ${PN}-${PV}.tar.gz. ${P} is expaned
to ${PN}-${PV} but it looks cleaner and matches our convention.
Also, if it is hosted by sourceforge, we could write it as
SRC_URI="mirror://sourceforge/latex2rtf/...". It will grab
files from one of sourceforge mirrors, which is better than
specifying only one mirror.
3) Although there are many ways to write `use' command in if - then
clause, it would be better to use
if use doc ; then
...
fi
or
if [ `use doc` ]; then
...
fi
or
if [ -n "`use doc`" ]
then
...
fi
or something similar. It is because if (use doc); then invokes
subshell to check whether use flag is set, but we don't actually
need to run subshell for that purpose.
Created attachment 26274 [details]
modified ebuild
Ok, I'm sending to you a modified ebuild acording to your remarks.
(excuse me, I don't know well the details of the Gentoo standards)
Please note that I've renamed my Makefile to Makefile-1.9.14
in order to make easier future updates
Created attachment 26275 [details]
a modified version of the Makefile
I've renamed it to Makefile-1.9.14 to make it easier updates
(by identifying the package version)
Also I've deleted some non necesary lines with anoying messages
I committed your ebuild(1.9.14) and the latest one (1.9.15) to Portage. Despite your first comment about creating Makefile, I extracted a diff from you Makefile-1.9.14 and applied it. This is because it makes it easier to upgrade (Makefile for 1.9.14 doesn't work for 1.9.15, but the patch for 1.9.15 works for 1.9.14 and vice versa). Also, I modified your patch because man and info directories in Gentoo are not /usr/man and /usr/info but /usr/share/man and /usr/share/info. Thanks for contributing the ebuild and giving us informative comments. |