| Summary: | New ebuild: x11-misc/tinymount - simple UDisks frontend | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Mike Limansky <limanski> |
| Component: | New packages | Assignee: | Samuli Suominen (RETIRED) <ssuominen> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | desktop-misc |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://github.com/limansky/tinymount | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
tinymount-0.2.4.ebuild
tinymount-0.2.4.ebuild tinymount-0.2.4.ebuild |
||
|
Description
Mike Limansky
2012-05-12 10:54:18 UTC
Created attachment 311501 [details]
tinymount-0.2.4.ebuild
Ebuild for latest stable version, but it also can be used as live ebuild.
I can see couple of minor issues: "unset SCM" should be added before the inherit line, at the top since this might be set in the environment to something unintended EAPI=4 should be used instead of EAPI=3 as latest is always preferred for new ebuilds Possible missing dev-util/pkgconfig in DEPEND? (In reply to comment #2) > I can see couple of minor issues: > > "unset SCM" should be added before the inherit line, at the top since this > might be set in the environment to something unintended Could you please provide more information about this variable? I've tried to find something about SCM variable but got nothing. > Possible missing dev-util/pkgconfig in DEPEND? Yes, pkgconfig is used. Should I use dev-util/pkgconfig or virtual/pkgconfig as dependency? (In reply to comment #3) > (In reply to comment #2) > > I can see couple of minor issues: > > > > "unset SCM" should be added before the inherit line, at the top since this > > might be set in the environment to something unintended > > Could you please provide more information about this variable? I've tried to > find something about SCM variable but got nothing. You are using it in the ebuild and that's all there is to tell about it. Look at how, for example, xine-lib's ebuild does "unset _live_inherits" to ensure the environment is clean: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-libs/xine-lib/xine-lib-1.2.1-r1.ebuild?view=markup > > Possible missing dev-util/pkgconfig in DEPEND? > > Yes, pkgconfig is used. Should I use dev-util/pkgconfig or virtual/pkgconfig > as dependency? Yeah, sorry, old customs die hard. Use virtual/pkgconfig. Created attachment 311543 [details]
tinymount-0.2.4.ebuild
Updated ebuild.
The only reservation I have left for adding this to tree is the fact that UDisks1 is obsolete and replaced by UDisks2, sys-fs/udisks:2 in Gentoo... And ebuild problems of:
${D} needs to be quoted ""
lang should be declared local in src_install() with 'local lang', just like params is in src_configure
KEYWORDS for ~arch shouldn't be available for live ebuilds, so KEYWORDS should be moved inside the if -block right next to SRC_URI
And some more minor issues of:
eqawarn "overuse" should propably be replaced with ewarn or die
(In reply to comment #6) > The only reservation I have left for adding this to tree is the fact that > UDisks1 is obsolete and replaced by UDisks2, sys-fs/udisks:2 in Gentoo... oh right, and for this the :0 or :2 SLOT dep is missing from the ebuild. Created attachment 311819 [details]
tinymount-0.2.4.ebuild
Updated according to comments.
mirror://github was not getting used, fixed that and did minor cosmetic changes and committed this to Portage let me know if you want yourself get added to metadata.xml for proxy-maintainership (In reply to comment #10) > mirror://github was not getting used, fixed that and did minor cosmetic > changes and committed this to Portage > > let me know if you want yourself get added to metadata.xml for > proxy-maintainership Yes, sure I would like to take care about the package. Is where any docs what and how should I do? BTW, I've found that there https://... url in EGIT_REPO_URI instead of git://.., but I think it's not critical, because the 9999 is not available. (In reply to comment #11) > (In reply to comment #10) > > mirror://github was not getting used, fixed that and did minor cosmetic > > changes and committed this to Portage > > > > let me know if you want yourself get added to metadata.xml for > > proxy-maintainership > > Yes, sure I would like to take care about the package. Is where any docs > what and how should I do? i've added you to metadata.xml file, so you will get all the bugs automatically, and I get just CC'd in those bugs then you write the patch and/or react to the bug, and once you are done, i'll commit your changes http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml > > BTW, I've found that there https://... url in EGIT_REPO_URI instead of > git://.., but I think it's not critical, because the 9999 is not available. fixed, ty |
