Summary: | >www-client/firefox-11 - get it working on HPPA again | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jeroen Roovers (RETIRED) <jer> |
Component: | Current packages | Assignee: | Mozilla Gentoo Team <mozilla> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | hppa |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | HPPA | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=502124 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 427612, 465396 | ||
Bug Blocks: | |||
Attachments: |
www-client:firefox-12.0:20120501-163518.log
firefox-12-414297.patch.out www-client:firefox-12.0-r1:20120524-022739.log www-client:firefox-15.0:20120904-153359.log firefox-20-stack_direction.patch www-client:firefox-20.0.1:20130429-123917.log with patch from attachment #346888 applied firefox-20-hppa.patch firefox-21-nativeStackLimit.patch |
Description
Jeroen Roovers (RETIRED)
2012-05-01 19:06:05 UTC
If you could swap out the patch and test or epatch_exclude it and apply patch with new name would be appreciated. https://bug691898.bugzilla.mozilla.org/attachment.cgi?id=620274 in mozilla overlay please let me know. Please keep it open or I will lose track of this (especially since this bug doesn't (rev)depend on another one. More on this later today. Created attachment 311295 [details]
firefox-12-414297.patch.out
* Done with patching
* Applying user patches from /etc/portage/patches//www-client/firefox ...
* firefox-12-414297.patch ...
* Failed Patch: firefox-12-414297.patch !
* ( /etc/portage/patches//www-client/firefox/firefox-12-414297.patch )
*
* Include in your bugreport the contents of:
*
* /mnt/alt/portage/www-client/firefox-12.0/temp/firefox-12-414297.patch.out
(In reply to comment #4) > Created attachment 311295 [details] > firefox-12-414297.patch.out > > * Done with patching > * Applying user patches from /etc/portage/patches//www-client/firefox ... > * firefox-12-414297.patch ... > > * Failed Patch: firefox-12-414297.patch ! > * ( /etc/portage/patches//www-client/firefox/firefox-12-414297.patch ) > * > * Include in your bugreport the contents of: > * > * > /mnt/alt/portage/www-client/firefox-12.0/temp/firefox-12-414297.patch.out Just change the patchset number to 0.2, or test from overlay, I know it will apply properly as I am currently running it on my ppc machine :) OK, I'll fix the patch revision locally. Index: firefox-12.0.ebuild =================================================================== RCS file: /var/cvsroot/gentoo-x86/www-client/firefox/firefox-12.0.ebuild,v retrieving revision 1.3 diff -u -B -r1.3 firefox-12.0.ebuild --- firefox-12.0.ebuild 3 May 2012 06:01:04 -0000 1.3 +++ firefox-12.0.ebuild 10 May 2012 03:17:02 -0000 @@ -27,7 +27,7 @@ # Changeset for alpha snapshot CHANGESET="e56ecd8b3a68" # Patch version -PATCH="${PN}-12.0-patches-0.1" +PATCH="${PN}-12.0-patches-0.2" # Upstream ftp release URI that's used by mozlinguas.eclass # We don't use the http mirror because it deletes old tarballs. MOZ_FTP_URI="ftp://ftp.mozilla.org/pub/${PN}/releases/" No, that didn't work. Is that patch in the URL up to date? (In reply to comment #7) > Index: firefox-12.0.ebuild > =================================================================== > RCS file: /var/cvsroot/gentoo-x86/www-client/firefox/firefox-12.0.ebuild,v > retrieving revision 1.3 > diff -u -B -r1.3 firefox-12.0.ebuild > --- firefox-12.0.ebuild 3 May 2012 06:01:04 -0000 1.3 > +++ firefox-12.0.ebuild 10 May 2012 03:17:02 -0000 > @@ -27,7 +27,7 @@ > # Changeset for alpha snapshot > CHANGESET="e56ecd8b3a68" > # Patch version > -PATCH="${PN}-12.0-patches-0.1" > +PATCH="${PN}-12.0-patches-0.2" > # Upstream ftp release URI that's used by mozlinguas.eclass > # We don't use the http mirror because it deletes old tarballs. > MOZ_FTP_URI="ftp://ftp.mozilla.org/pub/${PN}/releases/" > > No, that didn't work. Is that patch in the URL up to date? No the latestest patch is in 0.2 patchset already. Are you still seeing the same error or something completely different? (In reply to comment #8) > No the latestest patch is in 0.2 patchset already. Are you still seeing the > same error or something completely different? Ah, OK, so with the latestestest patchset, and without the local patch, it's now building again. No, it fails with patchset 2 with the very same error. And isn't that patch for bug #408613? (In reply to comment #10) > No, it fails with patchset 2 with the very same error. > > And isn't that patch for bug #408613? It is the port of the patch that is breaking it, appears Mike over in debian is using a different patch at the moment I will review it more tonight and see what we can do to either swap out with debian patch or update patch in gentoo to fix the issue once and for all. -r1 for both tb/fx-12 are now in tree please test and report. Nearly the same as before: /mnt/alt/portage/www-client/firefox-12.0-r1/work/mozilla-release/js/src/jsapi.cpp:3018:44: error: 'struct JSRuntime' has no member named 'nativeStackBase' Created attachment 312911 [details]
www-client:firefox-12.0-r1:20120524-022739.log
/mnt/alt/portage/www-client/firefox-13.0/work/mozilla-release/js/src/jsgc.cpp: In function 'void js::MarkConservativeStackRoots(JSTracer*, bool)': /mnt/alt/portage/www-client/firefox-13.0/work/mozilla-release/js/src/jsgc.cpp:1153:20: error: invalid conversion from 'uintptr_t' to 'uintptr_t*' In file included from /mnt/alt/portage/www-client/firefox-14.0.1/work/mozilla-release/mfbt/double-conversion/bignum-dtoa.h:31:0, from /mnt/alt/portage/www-client/firefox-14.0.1/work/mozilla-release/mfbt/double-conversion/bignum-dtoa.cc:30: /mnt/alt/portage/www-client/firefox-14.0.1/work/mozilla-release/mfbt/double-conversion/utils.h:67:2: error: #error Target architecture was not detected as supported by Double-Conversion. The problem seems to be ever shifting. :) Please test included patch found on additional bug. Created attachment 322928 [details]
www-client:firefox-15.0:20120904-153359.log
/mnt/alt/portage/www-client/firefox-15.0/work/mozilla-release/js/src/jsgc.cpp: In function 'void js::MarkConservativeStackRoots(JSTr
acer*, bool)':
/mnt/alt/portage/www-client/firefox-15.0/work/mozilla-release/js/src/jsgc.cpp:1081:20: error: invalid conversion from 'uintptr_t' to 'uintptr_t*'
Created attachment 346888 [details, diff]
firefox-20-stack_direction.patch
I am not sure this will work, but it brings the stack-grows-up case back in line with the opposite case.
Something else is still needed since the build fails later on with:
make[5]: *** No rule to make target `trunk/Makefile', needed by `export'. Stop.
I'll attach that build log shortly.
Created attachment 346890 [details] www-client:firefox-20.0.1:20130429-123917.log with patch from attachment #346888 [details, diff] applied It's probably near this horrible code: case "$CPU_ARCH" in x86_64 | ia64) WEBRTC_TARGET_ARCH=x64 No, ia64 = Itanium, and x86_64 = amd64 / x64. Wow. I think the following bit is what breaks the HPPA build: *) # unsupported arch for webrtc WEBRTC_TARGET_ARCH=unknown MOZ_WEBRTC= ;; IIRC this was fixed for many architectures in bug #444780 with a patch that went upstream. Created attachment 346960 [details, diff] firefox-20-hppa.patch Except for bug #465396, this fixes building on HPPA. Created attachment 349484 [details, diff] firefox-21-nativeStackLimit.patch Combined with attachment #346960 [details, diff], this allows building and running firefox-21 on HPPA. I have put both patches in FILESDIR and marked 21.0 for ~hppa. |