Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 413959

Summary: app-emulation/qemu-kvm: could you please add 'doc' USE?
Product: Gentoo Linux Reporter: kulti <kultihell>
Component: New packagesAssignee: Gentoo QEMU Project <qemu+disabled>
Status: RESOLVED CANTFIX    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=435534
Whiteboard:
Package list:
Runtime testing required: ---

Description kulti 2012-04-29 08:15:29 UTC
I'm not familar with ebuilds, but I think only two simple changes needed:
doc? ( app-text/texi2html )
---
if use_doc; then
  dohtml qemu-doc.html qemu-tech.html || die
fi

Reproducible: Always
Comment 1 Doug Goldstein (RETIRED) gentoo-dev 2012-07-08 20:24:32 UTC
Well we always include that depend and the dohtml call is always there. I've added USE=doc to call --enable-docs for the configure script in the qemu-kvm-1.1.0 ebuild
Comment 2 kulti 2012-07-12 20:48:51 UTC
Looks like partialy fix... I can't understandd, why app-text/texi2html dependencies still needed?

I fix it in local overlay to

 doc? ( app-text/texi2html )

Was built successfully.
Comment 3 Doug Goldstein (RETIRED) gentoo-dev 2012-07-12 21:51:46 UTC
(In reply to comment #2)
> Looks like partialy fix... I can't understandd, why app-text/texi2html
> dependencies still needed?
> 
> I fix it in local overlay to
> 
>  doc? ( app-text/texi2html )
> 
> Was built successfully.

Not really sure where you would have had to add that since we've already got:

DEPEND="${RDEPEND}
    app-text/texi2html
    virtual/pkgconfig
    kernel_linux? ( >=sys-kernel/linux-headers-2.6.35 )"

And its certainly not a run time depend, its used at build time.
Comment 4 kulti 2012-07-13 15:12:38 UTC
Yes, it's build dependencies, but I haven't texi2html in my system and not need it. So I cannot see any reason to stay hold it in build-dependency, when we can do it optional with doc USE-flag.


@@ -99,7 +99,7 @@ RDEPEND="
        xfs? ( sys-fs/xfsprogs )"
 
 DEPEND="${RDEPEND}
-       app-text/texi2html
+       doc? ( app-text/texi2html )
        virtual/pkgconfig
        kernel_linux? ( >=sys-kernel/linux-headers-2.6.35 )"
Comment 5 kulti 2012-08-14 19:33:32 UTC
Still need to be fixed. Please review my patch for texi2html dependency:
 DEPEND="${RDEPEND}
-       app-text/texi2html
+       doc? ( app-text/texi2html )
        virtual/pkgconfig
        kernel_linux? ( >=sys-kernel/linux-headers-2.6.35 )"
Comment 6 Doug Goldstein (RETIRED) gentoo-dev 2012-09-10 02:18:02 UTC
Fixed in tree.
Comment 7 Doug Goldstein (RETIRED) gentoo-dev 2013-05-15 14:45:59 UTC
Due to bug #435534, I'm going to have to revert this. This prevents man pages from being installed. Unfortunately there's only a big hammer for all docs (including man pages) and since we always want to install man pages this must always be on.

You are more than welcome to submit a patch upstream which breaks out man pages from other doc generation.
Comment 8 Doug Goldstein (RETIRED) gentoo-dev 2013-05-30 02:12:24 UTC
Reverted in qemu-1.4.2, due to #435534